[mlir] Remove duplicate comment(NFC) #128304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments in the source file duplicate the documentation already present in the header file `mlir/IR/Types.h`.
|
@llvm/pr-subscribers-mlir-core @llvm/pr-subscribers-mlir Author: Longsheng Mou (CoTinker) ChangesThe comments in the source file duplicate the documentation already present in the header file llvm-project/mlir/include/mlir/IR/Types.h Lines 136 to 141 in 876174f Full diff: https://github.com/llvm/llvm-project/pull/128304.diff 1 Files Affected:
diff --git a/mlir/lib/IR/Types.cpp b/mlir/lib/IR/Types.cpp
index bca90de6f4a8a..6af0c8af51ba0 100644
--- a/mlir/lib/IR/Types.cpp
+++ b/mlir/lib/IR/Types.cpp
@@ -46,7 +46,6 @@ bool Type::isIndex() const { return llvm::isa<IndexType>(*this); }
bool Type::isInteger() const { return llvm::isa<IntegerType>(*this); }
-/// Return true if this is an integer type with the specified width.
bool Type::isInteger(unsigned width) const {
if (auto intTy = llvm::dyn_cast<IntegerType>(*this))
return intTy.getWidth() == width;
|
|
Ping~ |
kuhar
approved these changes
Feb 28, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/94/builds/4839 Here is the relevant piece of the build log for the reference |
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
The comments in the source file duplicate the documentation already present in the header file `mlir/IR/Types.h`. https://github.com/llvm/llvm-project/blob/876174ffd7533dc220f94721173bb767b659fa7f/mlir/include/mlir/IR/Types.h#L136-L141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments in the source file duplicate the documentation already present in the header file
mlir/IR/Types.h.llvm-project/mlir/include/mlir/IR/Types.h
Lines 136 to 141 in 876174f