[OMPT] Use __tsan_init to detect TSan binaries rather than RunningOnValgrind #128357
Conversation
…ingOnValgrind Switch to using __tsan_init rather than RunningOnValgrind as the means for detecting TSan instumented binaries. RunningOnValgrind is present in other libraries (such as Google perftools tcmalloc). An exe that links with a tcmalloc static library and exports symbols with -rdynamic will appear to be TSan instrumented even when it is not resulting in "Unable to fint TSan function ..." messages. Fixes issue llvm#122319.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
llvmbot
added
openmp:libomp
openmp/tools/archer/ompt-tsan.cpp
Outdated
| // RunningOnValgrind is used to detect absence of TSan and must intentionally be a nullptr. | ||
| static int (*RunningOnValgrind)(void); | ||
| // __tsan_init is used to detect absence of TSan and must intentionally be a nullptr. | ||
| static void (*__tsan_init)(void); |
There was a problem hiding this comment.
Since the function is never called, I suggest to declare the variable locally in ompt_start_tool.
There was a problem hiding this comment.
Agreed. I just pushed a second change that does that.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Please fix the formatting then it's good to go |
Done. I'm not familiar with the LLVM workflow, sorry for missing that. |
|
@paulfloyd Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Switch to using __tsan_init rather than RunningOnValgrind as the means for detecting TSan instumented binaries. RunningOnValgrind is present in other libraries (such as Google perftools tcmalloc). An exe that links with a tcmalloc static library and exports symbols with -rdynamic will appear to be TSan instrumented even when it is not resulting in "Unable to fint TSan function ..." messages.
Fixes issue #122319.