[LivePhysReg] Fix off by 1 error in an assert. NFC #128379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty sure Reg should not be equal to the number of registers.
arsenm
approved these changes
Feb 23, 2025
|
@llvm/pr-subscribers-llvm-regalloc Author: Craig Topper (topperc) ChangesPretty sure Reg should not be equal to the number of registers. Full diff: https://github.com/llvm/llvm-project/pull/128379.diff 1 Files Affected:
diff --git a/llvm/include/llvm/CodeGen/LivePhysRegs.h b/llvm/include/llvm/CodeGen/LivePhysRegs.h
index 037905119eb22..696e8a0c5dd59 100644
--- a/llvm/include/llvm/CodeGen/LivePhysRegs.h
+++ b/llvm/include/llvm/CodeGen/LivePhysRegs.h
@@ -82,7 +82,7 @@ class LivePhysRegs {
/// Adds a physical register and all its sub-registers to the set.
void addReg(MCPhysReg Reg) {
assert(TRI && "LivePhysRegs is not initialized.");
- assert(Reg <= TRI->getNumRegs() && "Expected a physical register.");
+ assert(Reg < TRI->getNumRegs() && "Expected a physical register.");
for (MCPhysReg SubReg : TRI->subregs_inclusive(Reg))
LiveRegs.insert(SubReg);
}
@@ -91,7 +91,7 @@ class LivePhysRegs {
/// super-registers from the set.
void removeReg(MCPhysReg Reg) {
assert(TRI && "LivePhysRegs is not initialized.");
- assert(Reg <= TRI->getNumRegs() && "Expected a physical register.");
+ assert(Reg < TRI->getNumRegs() && "Expected a physical register.");
for (MCRegAliasIterator R(Reg, TRI, true); R.isValid(); ++R)
LiveRegs.erase((*R).id());
}
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/6/builds/7034 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty sure Reg should not be equal to the number of registers.