Skip to content

[MLIR][Affine] NFC. Fix outdated comment in affine analysis utils #128406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

bondhugula
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Feb 23, 2025

@llvm/pr-subscribers-mlir

Author: Uday Bondhugula (bondhugula)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/128406.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Affine/Analysis/Utils.cpp (+2-3)
diff --git a/mlir/lib/Dialect/Affine/Analysis/Utils.cpp b/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
index 7f06bc5160b9d..ba6f045cff408 100644
--- a/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
+++ b/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
@@ -282,9 +282,8 @@ bool MemRefDependenceGraph::init() {
       // Create graph node for top-level op unless it is known to be
       // memory-effect free. This covers all unknown/unregistered ops,
       // non-affine ops with memory effects, and region-holding ops with a
-      // well-defined control flow. During the fusion validity checks, we look
-      // for non-affine ops on the path from source to destination, at which
-      // point we check which memrefs if any are used in the region.
+      // well-defined control flow. During the fusion validity checks, edges
+      // to/from these ops get looked at.
       Node *node = addNodeToMDG(&op, *this, memrefAccesses);
       if (!node)
         return false;

@llvmbot
Copy link
Member

llvmbot commented Feb 23, 2025

@llvm/pr-subscribers-mlir-affine

Author: Uday Bondhugula (bondhugula)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/128406.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Affine/Analysis/Utils.cpp (+2-3)
diff --git a/mlir/lib/Dialect/Affine/Analysis/Utils.cpp b/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
index 7f06bc5160b9d..ba6f045cff408 100644
--- a/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
+++ b/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
@@ -282,9 +282,8 @@ bool MemRefDependenceGraph::init() {
       // Create graph node for top-level op unless it is known to be
       // memory-effect free. This covers all unknown/unregistered ops,
       // non-affine ops with memory effects, and region-holding ops with a
-      // well-defined control flow. During the fusion validity checks, we look
-      // for non-affine ops on the path from source to destination, at which
-      // point we check which memrefs if any are used in the region.
+      // well-defined control flow. During the fusion validity checks, edges
+      // to/from these ops get looked at.
       Node *node = addNodeToMDG(&op, *this, memrefAccesses);
       if (!node)
         return false;

@bondhugula
Copy link
Contributor Author

NFC comment update, merging.

@bondhugula bondhugula merged commit 8ff4d27 into llvm:main Feb 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants