[mlir] Fix integration test when %host_cc path contains spaces
#128439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-memref Author: Ivan Butygin (Hardcode84) ChangesFull diff: https://github.com/llvm/llvm-project/pull/128439.diff 1 Files Affected:
diff --git a/mlir/test/Integration/Dialect/MemRef/memref_abi.c b/mlir/test/Integration/Dialect/MemRef/memref_abi.c
index 3fb19177deb09..110ab449b5a34 100644
--- a/mlir/test/Integration/Dialect/MemRef/memref_abi.c
+++ b/mlir/test/Integration/Dialect/MemRef/memref_abi.c
@@ -12,7 +12,7 @@
// RUN: llc %t.ll -o %t.o -filetype=obj
// Compile the current C file and link it to the MLIR code:
-// RUN: %host_cc %s %t.o -o %t.exe
+// RUN: "%host_cc" %s %t.o -o %t.exe
// Exec
// RUN: %t.exe | FileCheck %s
|
joker-eph
approved these changes
Feb 23, 2025
joker-eph
added a commit
that referenced
this pull request
Feb 24, 2025
…ces" (#128573) Reverts #128439 Builtbot are broken, see: https://lab.llvm.org/buildbot/#/builders/138/builds/10710
|
Unfortunately this broke the bots: https://lab.llvm.org/buildbot/#/builders/116/builds/10679 There is a trailing space somehow in the path to clang there, not sure why? |
Hardcode84
added a commit
to Hardcode84/llvm-project
that referenced
this pull request
Feb 24, 2025
Continuation of llvm#128439 Some builders have spaces at the end of the host_cc path, which now breaks.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 24, 2025
…ontains spaces" (#128573) Reverts llvm/llvm-project#128439 Builtbot are broken, see: https://lab.llvm.org/buildbot/#/builders/138/builds/10710
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 24, 2025
…ains spaces (#128542) Reland llvm/llvm-project#128439 Some builders have spaces at the end of the `host_cc` path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.