MachineFunction: Remove null check on TargetRegisterInfo #128480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Targets are required to define this, it is not optional. Make the method pure virtual to enforce this
arsenm
requested review from
davemgreen,
jayfoad,
MatzeB,
qcolombet,
RKSimon,
Sisyph and
topperc
RKSimon
reviewed
Feb 24, 2025
TargetInstrInfo / TargetRegisterInfo use an inconsistent mix of pure and cases with default implementations which are just llvm_unreachable. I don't think it matters, or why TargetSubtargetInfo would be any different. In this case, I don't know why these aren't just required fields in the base class the subclass constructor is required to set |
RKSimon
approved these changes
Feb 24, 2025
arsenm
deleted the
users/arsenm/machine-function-remove-null-tri-check
branch
farzonl
added a commit
to farzonl/llvm-project
that referenced
this pull request
Feb 24, 2025
1. Fix build break caused by llvm#126772 by adding `writeDISubrangeType` stub to `DXILBitcodeWriter.cpp` 2. Fix build break caused by llvm#128480 by adding implementation of pure virtual method `TargetSubtargetInfo::getRegisterInfo`
farzonl
added a commit
to farzonl/llvm-project
that referenced
this pull request
Feb 24, 2025
1. Fix build break caused by llvm#126772 by adding `writeDISubrangeType` stub to `DXILBitcodeWriter.cpp` 2. Fix build break caused by llvm#128480 by adding implementation of pure virtual method `TargetSubtargetInfo::getRegisterInfo`
farzonl
added a commit
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets are required to define this, it is not optional. Make the method
pure virtual to enforce this