Skip to content

InstCombine: Remove a check for pointer bitcasts #128491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025
Merged

InstCombine: Remove a check for pointer bitcasts #128491

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62d9df3
InstCombine: Remove a check for pointer bitcasts
arsenm Feb 24, 2025
ba237ae
Update comment
arsenm Feb 24, 2025
9d870a2
Inline lambda
arsenm Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3656,20 +3656,15 @@ Instruction *InstCombinerImpl::visitUnconditionalBranchInst(BranchInst &BI) {
assert(BI.isUnconditional() && "Only for unconditional branches.");

// If this store is the second-to-last instruction in the basic block
// (excluding debug info and bitcasts of pointers) and if the block ends with
// (excluding debug info) and if the block ends with
// an unconditional branch, try to move the store to the successor block.

auto GetLastSinkableStore = [](BasicBlock::iterator BBI) {
auto IsNoopInstrForStoreMerging = [](BasicBlock::iterator BBI) {
return BBI->isDebugOrPseudoInst() ||
(isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy());
};

BasicBlock::iterator FirstInstr = BBI->getParent()->begin();
do {
if (BBI != FirstInstr)
--BBI;
} while (BBI != FirstInstr && IsNoopInstrForStoreMerging(BBI));
} while (BBI != FirstInstr && BBI->isDebugOrPseudoInst());

return dyn_cast<StoreInst>(BBI);
};
Expand Down
Loading