Skip to content

[MLGO] Refactored verbosity flag in mlgo-utils to common location #128541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions llvm/utils/mlgo-utils/mlgo/corpus/combine_training_corpus.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import logging

from mlgo.corpus import combine_training_corpus_lib
from mlgo.corpus import flags


def parse_args_and_run():
Expand All @@ -36,15 +37,7 @@ def parse_args_and_run():
parser.add_argument(
"--root_dir", type=str, help="The root dir of module paths to combine."
)
# TODO(#107898): Refactor this into a common location.
parser.add_argument(
"--verbosity",
type=str,
help="The verbosity level to use for logging",
default="INFO",
nargs="?",
choices=["DEBUG", "INFO", "WARNING", "ERROR"],
)
flags.add_verbosity_arguments(parser)
args = parser.parse_args()
main(args)

Expand Down
11 changes: 2 additions & 9 deletions llvm/utils/mlgo-utils/mlgo/corpus/extract_ir.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import logging

from mlgo.corpus import extract_ir_lib
from mlgo.corpus import flags


def parse_args_and_run():
Expand Down Expand Up @@ -111,15 +112,7 @@ def parse_args_and_run():
default=".llvmbc",
nargs="?",
)
# TODO(#107898): Refactor this into a common location.
parser.add_argument(
"--verbosity",
type=str,
help="The verbosity level to use for logging",
default="INFO",
nargs="?",
choices=["DEBUG", "INFO", "WARNING", "ERROR"],
)
flags.add_verbosity_arguments(parser)
args = parser.parse_args()
main(args)

Expand Down
22 changes: 22 additions & 0 deletions llvm/utils/mlgo-utils/mlgo/corpus/flags.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
"""Library functions for setting up common parser arguments"""

from argparse import ArgumentParser


def add_verbosity_arguments(parser: ArgumentParser) -> None:
"""Adds the arguments for verbosity to the ArgumentParser

Arguments:
parser: The argument parser being modified with verbosity arguments.
"""
parser.add_argument(
"--verbosity",
type=str,
help="The verbosity level to use for logging",
default="INFO",
nargs="?",
choices=["DEBUG", "INFO", "WARNING", "ERROR"],
)
Loading