[Clang][LLVM] Implement multi-multi vectors MOP4{A/S} #129230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virginia-cangelosi
force-pushed
the
mu_mu_vec
branch
2 times, most recently
from
a5c547f to
62bf165
Compare
Lukacma
reviewed
Mar 10, 2025
| [IsStreaming, IsInOutZA], | ||
| checks>; | ||
| def _2x2 : SInst<"svmop4" # mode # "[_2x2]_" # za # "[_{d}_{3}]", | ||
| "vi2.x2.u", t, MergeNone, "aarch64_sme_sumop4" # mode # i # "_wide_2x2", |
There was a problem hiding this comment.
Suggested change
| "vi2.x2.u", t, MergeNone, "aarch64_sme_sumop4" # mode # i # "_wide_2x2", | |
| "vi22.u", t, MergeNone, "aarch64_sme_sumop4" # mode # i # "_wide_2x2", |
| [IsStreaming, IsInOutZA], | ||
| checks>; | ||
| def _2x2 : SInst<"svmop4" # mode # "[_2x2]_" # za # "[_{d}_{3}]", | ||
| "vi2.u2.x", t, MergeNone, "aarch64_sme_usmop4" # mode # i # "_wide_2x2", |
There was a problem hiding this comment.
Suggested change
| "vi2.u2.x", t, MergeNone, "aarch64_sme_usmop4" # mode # i # "_wide_2x2", | |
| "vi22.x", t, MergeNone, "aarch64_sme_usmop4" # mode # i # "_wide_2x2", |
clang/include/clang/Basic/arm_sme.td
Outdated
| "vi2u", t, MergeNone, "aarch64_sme_sumop4" # mode # i # "_wide_2x1", | ||
| [IsStreaming, IsInOutZA], | ||
| checks>; | ||
| def _2x2 : SInst<"svmop4" # mode # "[_2x2]_" # za # "[_{d}_{3}]", |
There was a problem hiding this comment.
s/"[2x2]" /"[2x2]"/
and # za # value should start with ''
clang/include/clang/Basic/arm_sme.td
Outdated
| } | ||
|
|
||
| let SMETargetGuard = "sme2,sme-mop4" in { | ||
| defm SVFMOP4A_HtoS : MOP4<"a", "za32", "hb", "aarch64_sme_mop4a_wide", [ImmCheck<0, ImmCheck0_3>]>; |
There was a problem hiding this comment.
I believe this patch will be rebased, when this is done the _ at the should be gone
virginia-cangelosi
force-pushed
the
mu_mu_vec
branch
from
62bf165 to
7c7e50a
Compare
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/19320 Here is the relevant piece of the build log for the reference |
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
Apr 2, 2025
Implement all multi-multi {BF/F/S/U/SU/US}MOP4{A/S} instructions in
clang and llvm following the acle in
https://github.com/ARM-software/acle/pull/381/files
jthackray
added a commit
to jthackray/llvm-project
that referenced
this pull request
Apr 7, 2025
Fix some of the recently-added tests (PRs llvm#127797, llvm#128854, llvm#129226 and llvm#129230) which were incorrectly defined.
jthackray
added a commit
that referenced
this pull request
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement all multi-multi {BF/F/S/U/SU/US}MOP4{A/S} instructions in clang and llvm following the acle in https://github.com/ARM-software/acle/pull/381/files