Skip to content

[Offload][AMDGPU] Enable SPIRV target in build conf #129323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

jplehr
Copy link
Contributor

@jplehr jplehr commented Feb 28, 2025

Enable the SPIRV backend on the CMake-cache file buildbots.

Enable the SPIRV backend on the CMake-cache file buildbots.
@llvmbot
Copy link
Member

llvmbot commented Feb 28, 2025

@llvm/pr-subscribers-offload

@llvm/pr-subscribers-backend-amdgpu

Author: Jan Patrick Lehr (jplehr)

Changes

Enable the SPIRV backend on the CMake-cache file buildbots.


Full diff: https://github.com/llvm/llvm-project/pull/129323.diff

1 Files Affected:

  • (modified) offload/cmake/caches/AMDGPUBot.cmake (+1-1)
diff --git a/offload/cmake/caches/AMDGPUBot.cmake b/offload/cmake/caches/AMDGPUBot.cmake
index f04f3de2cb145..521841166be82 100644
--- a/offload/cmake/caches/AMDGPUBot.cmake
+++ b/offload/cmake/caches/AMDGPUBot.cmake
@@ -14,7 +14,7 @@ set(LLVM_ENABLE_RUNTIMES "compiler-rt;openmp;offload" CACHE STRING "")
 
 set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR ON CACHE BOOL "")
 set(LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "")
-set(LLVM_TARGETS_TO_BUILD "host;AMDGPU" CACHE STRING "")
+set(LLVM_TARGETS_TO_BUILD "host;AMDGPU;SPIRV" CACHE STRING "")
 set(LLVM_LIT_ARGS "-v --show-unsupported --timeout 100 --show-xfail -j 32" CACHE STRING "")
 
 set(CLANG_DEFAULT_LINKER "lld" CACHE STRING "")

@jplehr
Copy link
Contributor Author

jplehr commented Feb 28, 2025

In case this is OK, I'll land this on the weekend to see how much damage (if any) it does to our buildbots while not disrupting too many people.

Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's reasonable to turn this on because we are targeting SPIR-V for AMD machines and want coverage, but it's not reasonable to make this the solution for failing tests.

Copy link
Contributor

@AlexVlx AlexVlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jplehr
Copy link
Contributor Author

jplehr commented Feb 28, 2025

It's reasonable to turn this on because we are targeting SPIR-V for AMD machines and want coverage, but it's not reasonable to make this the solution for failing tests.

Agreed. We also still have bots that do not turn on this target.

@jplehr jplehr merged commit fe18796 into llvm:main Mar 1, 2025
12 checks passed
jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
Enable the SPIRV backend on the CMake-cache file buildbots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants