[mlir][tosa] Add missing controlflow extension comment #129338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous patch(llvm#128216) that added the support for the control flow extension overlooked adding a comment. This patch adds the comment. Change-Id: I5f922e23c6eecdef70968d5ee3e986446dd147de Signed-off-by: Luke Hutton <[email protected]>
|
@llvm/pr-subscribers-mlir-tosa @llvm/pr-subscribers-mlir Author: Jerry-Ge (Jerry-Ge) ChangesA previous patch(#128216) that added the support for the control flow extension overlooked adding a comment. This patch adds the comment. Full diff: https://github.com/llvm/llvm-project/pull/129338.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td
index ce17ad9362227..dceac03375606 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td
@@ -233,6 +233,7 @@ class Tosa_I32EnumAttr<string name, string description, string mnemonic,
// FP8E5M2 : 8-bit floating-point operations E5M2.
// FFT : Fast Fourier Transform operations.
// VARIABLE : Stateful variable operations.
+// CONTROLFLOW : Control Flow operations.
//===----------------------------------------------------------------------===//
def Tosa_NONE : I32EnumAttrCase<"none", 0>;
|
lhutton1
approved these changes
Mar 1, 2025
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
A previous patch(llvm#128216) that added the support for the control flow extension overlooked adding a comment. This patch adds the comment. Signed-off-by: Luke Hutton <[email protected]> Co-authored-by: Luke Hutton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous patch(#128216) that added the support for the control flow extension overlooked adding a comment. This patch adds the comment.