Skip to content

[libc] Added type-generic macros for fixed-point functions #129371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 9, 2025
Merged

[libc] Added type-generic macros for fixed-point functions #129371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc55d8c
added type-generic macros for abs, countls and round
lazyprop Mar 1, 2025
e53d151
the macros should not invoke cpp namespace
lazyprop Mar 5, 2025
1e6be62
clang-format stdfix-macros.h
lazyprop Mar 6, 2025
8d35583
use accum instead of _Accum
lazyprop Mar 6, 2025
0c30e06
run git-clang-format on the entire branch
lazyprop Mar 6, 2025
0c03b23
Merge branch 'main' into fixpoint-macros
lazyprop Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions libc/include/llvm-libc-macros/stdfix-macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,45 @@
#define ULACCUM_EPSILON 0x1.0p-32ULK
#endif // ULACCUM_EPSILON

#define absfx(x) \
_Generic((x), \
fract: absr, \
short fract: abshr, \
long fract: abslr, \
accum: absk, \
short accum: abshk, \
long accum: abslk)(x)

#define countlsfx(x) \
_Generic((x), \
fract: countlsr, \
short fract: countlshr, \
long fract: countlslr, \
accum: countlsk, \
short accum: countlshk, \
long accum: countlslk, \
unsigned fract: countlsur, \
unsigned short fract: countlsuhr, \
unsigned long fract: countlsulr, \
unsigned accum: countlsuk, \
unsigned short accum: countlsuhk, \
unsigned long accum: countlsulk)(x)

#define roundfx(x, y) \
_Generic((x), \
fract: roundr, \
short fract: roundhr, \
long fract: roundlr, \
accum: roundk, \
short accum: roundhk, \
long accum: roundlk, \
unsigned fract: roundur, \
unsigned short fract: rounduhr, \
unsigned long fract: roundulr, \
unsigned accum: rounduk, \
unsigned short accum: rounduhk, \
unsigned long accum: roundulk)(x, y)

#endif // LIBC_COMPILER_HAS_FIXED_POINT

#endif // LLVM_LIBC_MACROS_STDFIX_MACROS_H
8 changes: 7 additions & 1 deletion libc/include/stdfix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
header: stdfix.h
header_template: stdfix.h.def
macros: []
macros:
- macro_name: absfx
macro_header: stdfix-macros.h
- macro_name: countlsfx
macro_header: stdfix-macros.h
- macro_name: roundfx
macro_header: stdfix-macros.h
types:
- type_name: stdfix-types
enums: []
Expand Down
23 changes: 23 additions & 0 deletions libc/test/src/stdfix/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ endif()

add_custom_target(libc-stdfix-tests)


foreach(suffix IN ITEMS hr r lr hk k lk)
add_libc_test(
abs${suffix}_test
Expand Down Expand Up @@ -176,3 +177,25 @@ add_libc_test(
libc.src.__support.fixed_point.fx_rep
libc.src.__support.FPUtil.basic_operations
)

set(macros_depends)

foreach(s IN ITEMS r hr lr k hk lk)
list(APPEND macros_depends
libc.src.stdfix.abs${s}
libc.src.stdfix.countls${s}
libc.src.stdfix.countlsu${s}
libc.src.stdfix.round${s}
libc.src.stdfix.roundu${s}
)
endforeach()

add_libc_test(
macros_test
SUITE libc-stdfix-tests
SRCS macros_test.cpp
DEPENDS
libc.include.stdfix
${macros_depends}
)

113 changes: 113 additions & 0 deletions libc/test/src/stdfix/macros_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
//===-- Unittests for absfx -----------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#include "AbsTest.h"
#include "src/stdfix/abshk.h"
#include "src/stdfix/abshr.h"
#include "src/stdfix/absk.h"
#include "src/stdfix/abslk.h"
#include "src/stdfix/abslr.h"
#include "src/stdfix/absr.h"

#include "src/stdfix/countlshk.h"
#include "src/stdfix/countlshr.h"
#include "src/stdfix/countlsk.h"
#include "src/stdfix/countlslk.h"
#include "src/stdfix/countlslr.h"
#include "src/stdfix/countlsr.h"
#include "src/stdfix/countlsuhk.h"
#include "src/stdfix/countlsuhr.h"
#include "src/stdfix/countlsuk.h"
#include "src/stdfix/countlsulk.h"
#include "src/stdfix/countlsulr.h"
#include "src/stdfix/countlsur.h"

#include "src/stdfix/roundhk.h"
#include "src/stdfix/roundhr.h"
#include "src/stdfix/roundk.h"
#include "src/stdfix/roundlk.h"
#include "src/stdfix/roundlr.h"
#include "src/stdfix/roundr.h"
#include "src/stdfix/rounduhk.h"
#include "src/stdfix/rounduhr.h"
#include "src/stdfix/rounduk.h"
#include "src/stdfix/roundulk.h"
#include "src/stdfix/roundulr.h"
#include "src/stdfix/roundur.h"

using LIBC_NAMESPACE::abshk;
using LIBC_NAMESPACE::abshr;
using LIBC_NAMESPACE::absk;
using LIBC_NAMESPACE::abslk;
using LIBC_NAMESPACE::abslr;
using LIBC_NAMESPACE::absr;
using LIBC_NAMESPACE::countlshk;
using LIBC_NAMESPACE::countlshr;
using LIBC_NAMESPACE::countlsk;
using LIBC_NAMESPACE::countlslk;
using LIBC_NAMESPACE::countlslr;
using LIBC_NAMESPACE::countlsr;
using LIBC_NAMESPACE::countlsuhk;
using LIBC_NAMESPACE::countlsuhr;
using LIBC_NAMESPACE::countlsuk;
using LIBC_NAMESPACE::countlsulk;
using LIBC_NAMESPACE::countlsulr;
using LIBC_NAMESPACE::countlsur;
using LIBC_NAMESPACE::roundhk;
using LIBC_NAMESPACE::roundhr;
using LIBC_NAMESPACE::roundk;
using LIBC_NAMESPACE::roundlk;
using LIBC_NAMESPACE::roundlr;
using LIBC_NAMESPACE::roundr;
using LIBC_NAMESPACE::rounduhk;
using LIBC_NAMESPACE::rounduhr;
using LIBC_NAMESPACE::rounduk;
using LIBC_NAMESPACE::roundulk;
using LIBC_NAMESPACE::roundulr;
using LIBC_NAMESPACE::roundur;

TEST(LlvmLibcAbsfxTest, Basic) {
ASSERT_EQ(absfx(-0.5r), absr(-0.5r));
ASSERT_EQ(absfx(-0.5hr), abshr(-0.5hr));
ASSERT_EQ(absfx(-0.5lr), abslr(-0.5lr));
ASSERT_EQ(absfx(-0.5k), absk(-0.5k));
ASSERT_EQ(absfx(-0.5hk), abshk(-0.5hk));
ASSERT_EQ(absfx(-0.5lk), abslk(-0.5lk));
}

TEST(LlvmLibcRoundfxTest, Basic) {
ASSERT_EQ(roundfx(0.75r, 0), roundr(0.75r, 0));
ASSERT_EQ(roundfx(0.75hr, 0), roundhr(0.75hr, 0));
ASSERT_EQ(roundfx(0.75lr, 0), roundlr(0.75lr, 0));
ASSERT_EQ(roundfx(0.75k, 0), roundk(0.75k, 0));
ASSERT_EQ(roundfx(0.75hk, 0), roundhk(0.75hk, 0));
ASSERT_EQ(roundfx(0.75lk, 0), roundlk(0.75lk, 0));

ASSERT_EQ(roundfx(0.75ur, 0), roundur(0.75ur, 0));
ASSERT_EQ(roundfx(0.75uhr, 0), rounduhr(0.75uhr, 0));
ASSERT_EQ(roundfx(0.75ulr, 0), roundulr(0.75ulr, 0));
ASSERT_EQ(roundfx(0.75uk, 0), rounduk(0.75uk, 0));
ASSERT_EQ(roundfx(0.75uhk, 0), rounduhk(0.75uhk, 0));
ASSERT_EQ(roundfx(0.75ulk, 0), roundulk(0.75ulk, 0));
}

TEST(LlvmLibcCountlsfxTest, Basic) {
ASSERT_EQ(countlsfx(0.5r), countlsr(0.5r));
ASSERT_EQ(countlsfx(0.5hr), countlshr(0.5hr));
ASSERT_EQ(countlsfx(0.5lr), countlslr(0.5lr));
ASSERT_EQ(countlsfx(0.5k), countlsk(0.5k));
ASSERT_EQ(countlsfx(0.5hk), countlshk(0.5hk));
ASSERT_EQ(countlsfx(0.5lk), countlslk(0.5lk));

ASSERT_EQ(countlsfx(0.5ur), countlsur(0.5ur));
ASSERT_EQ(countlsfx(0.5uhr), countlsuhr(0.5uhr));
ASSERT_EQ(countlsfx(0.5ulr), countlsulr(0.5ulr));
ASSERT_EQ(countlsfx(0.5uk), countlsuk(0.5uk));
ASSERT_EQ(countlsfx(0.5uhk), countlsuhk(0.5uhk));
ASSERT_EQ(countlsfx(0.5ulk), countlsulk(0.5ulk));
}
Loading