Skip to content

[LLD][COFF] Correct relocation size comments in autoimport tests (NFC) #129403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

cjacek
Copy link
Contributor

@cjacek cjacek commented Mar 1, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Mar 1, 2025

@llvm/pr-subscribers-lld-coff

@llvm/pr-subscribers-lld

Author: Jacek Caban (cjacek)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/129403.diff

2 Files Affected:

  • (modified) lld/test/COFF/autoimport-arm64-data.s (+1-1)
  • (modified) lld/test/COFF/autoimport-arm64ec-data.test (+2-2)
diff --git a/lld/test/COFF/autoimport-arm64-data.s b/lld/test/COFF/autoimport-arm64-data.s
index b49bd4f89c97c..7934e2a969257 100644
--- a/lld/test/COFF/autoimport-arm64-data.s
+++ b/lld/test/COFF/autoimport-arm64-data.s
@@ -19,7 +19,7 @@
 
 # Runtime pseudo reloc list header consisting of 0x0, 0x0, 0x1.
 # First runtime pseudo reloc, with import from 0x2070,
-# applied at 0x3000, with a size of 32 bits.
+# applied at 0x3000, with a size of 64 bits.
 # CONTENTS: Contents of section .rdata:
 # CONTENTS:  140002000 00000000 00000000 01000000 70200000
 # CONTENTS:  140002010 00300000 40000000
diff --git a/lld/test/COFF/autoimport-arm64ec-data.test b/lld/test/COFF/autoimport-arm64ec-data.test
index 4d71b55f651a6..1f22ca4917557 100644
--- a/lld/test/COFF/autoimport-arm64ec-data.test
+++ b/lld/test/COFF/autoimport-arm64ec-data.test
@@ -19,9 +19,9 @@ IMPORTS-NEXT: }
 
 Runtime pseudo relocation list header at 0x401c, consisting of 0x0, 0x0, 0x1.
 The first runtime pseudo relocation is from an x86_64 object file, with import
-from 0x3000, applied at 0x7000 with a size of 32 bits. The second pseudo
+from 0x3000, applied at 0x7000 with a size of 64 bits. The second pseudo
 relocation is from an ARM64EC object file, with import from 0x3000, applied
-at 0x7008 with a size of 32 bits.
+at 0x7008 with a size of 64 bits.
 
 CONTENTS: Contents of section .rdata:
 CONTENTS:  180004010 00200000 10200000 00200000 00000000

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cjacek cjacek merged commit f858ac7 into llvm:main Mar 2, 2025
14 checks passed
@cjacek cjacek deleted the autoimport-comment branch March 2, 2025 12:10
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request Mar 10, 2025
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request Mar 20, 2025
jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request Apr 2, 2025
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request Apr 17, 2025
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request Apr 30, 2025
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request May 15, 2025
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request May 29, 2025
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants