-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[Github] Hash Pin Actions in Most Workflows #129486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,12 +60,12 @@ jobs: | |
# a local checkout beforehand. | ||
- name: Fetch LLVM sources (Push) | ||
if: ${{ github.event_name == 'push' }} | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
with: | ||
fetch-depth: 1 | ||
- name: Get subprojects that have doc changes | ||
id: docs-changed-subprojects | ||
uses: tj-actions/changed-files@v39 | ||
uses: tj-actions/changed-files@fea790cb660e33aef4bdf07304e28fedd77dfa13 # v39.2.4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was good timing: https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised May still be worth an audit regardless. CC @tstellar There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah. It was really good timing. I changed to the StepSecurity fork when the actions were taken down (6616acd). I want to do at least look at all the third party actions we're using and maybe even reimplement some of the simple ones to reduce risk. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This is a good idea. Lots of them won't be too difficult to replace with direct calls to the GitHub REST/GraphQL API. We may also want to create an allowlist of third-party actions that can be used in LLVM organisation repos. This can be configured in the repo settings so that workflows that use actions not on the allowlist will fail to execute and error out. |
||
with: | ||
files_yaml: | | ||
llvm: | ||
|
@@ -98,11 +98,11 @@ jobs: | |
- '.github/workflows/docs.yml' | ||
- name: Fetch LLVM sources (PR) | ||
if: ${{ github.event_name == 'pull_request' }} | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
with: | ||
fetch-depth: 1 | ||
- name: Setup Python env | ||
uses: actions/setup-python@v5 | ||
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0 | ||
with: | ||
python-version: '3.11' | ||
cache: 'pip' | ||
|
@@ -216,7 +216,7 @@ jobs: | |
mkdir built-docs/flang | ||
cp -r flang-build/docs/* built-docs/flang/ | ||
- name: Upload docs | ||
uses: actions/upload-artifact@v4 | ||
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0 | ||
with: | ||
name: docs-output | ||
path: built-docs/ |
Uh oh!
There was an error while loading. Please reload this page.