-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[LLDB][Docstrings] Fix some poorly formatted Docstrings #129605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) ChangesI was looking earlier on the public doc website, and noticed the markdown was very badly mangled for this recent docstring that I added. So I'm dropping the backticks and just leaving the snippet. Full diff: https://github.com/llvm/llvm-project/pull/129605.diff 1 Files Affected:
diff --git a/lldb/bindings/interface/SBProcessDocstrings.i b/lldb/bindings/interface/SBProcessDocstrings.i
index b5b22052a6094..e2348795d10d9 100644
--- a/lldb/bindings/interface/SBProcessDocstrings.i
+++ b/lldb/bindings/interface/SBProcessDocstrings.i
@@ -261,11 +261,11 @@ SBProcess supports thread iteration. For example (from test/lldbutil.py), ::
%feature("docstring", "
Get a list of all the memory regions associated with this process.
- ```
- readable_regions = []
- for region in process.GetMemoryRegions():
- if region.IsReadable():
- readable_regions.append(region)
- ```
+
+ readable_regions = []
+ for region in process.GetMemoryRegions():
+ if region.IsReadable():
+ readable_regions.append(region)
+
"
) lldb::SBProcess::GetMemoryRegions;
|
@JDevlieghere I should've closed this, but I'm actually going to fix a couple spots around the codebase. It looks like Swig will give a codeblock on Is there a good place to add a blurb about these swig gotcha's? Maybe a |
@clayborg These are those docstring cleanups I pinged you about |
c942934
to
fff16a7
Compare
That's a great question. There's a lot of institutional knowledge about how SWIG is used in LLDB that hasn't been written down. I think it'd be worth it to have a page on the website (under the section "developing lldb") to cover that. I'd be happy to contribute with some of the caveats/challenges/intricacies of how we use SWIG in LLDB. |
I was looking earlier on the public doc website, and noticed the markdown was very badly mangled for this recent docstring that I added. So I'm dropping the backticks and just leaving the snippet. 
I was looking earlier on the public doc website, and noticed the markdown was very badly mangled for this recent docstring that I added. So I'm dropping the backticks and just leaving the snippet.