Skip to content

[CI] Extend metrics container to log BuildKite metrics #129699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 11, 2025
Merged

Conversation

Keenuts
Copy link
Contributor

@Keenuts Keenuts commented Mar 4, 2025

The current container focuses on Github metrics. Before deprecating BuildKite, we want to make sure the new infra quality is better, or at least the same.

Being able to compare buildkite metrics with github metrics on grafana will allow us to easily present the comparison.

This PR requires llvm/llvm-zorg#400 to be merged first.

@Keenuts Keenuts requested a review from boomanaiden154 March 4, 2025 12:48
Copy link

github-actions bot commented Mar 4, 2025

✅ With the latest revision this PR passed the Python code formatter.

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, pretty much all just nits. This overall looks pretty good!

@Keenuts Keenuts requested a review from boomanaiden154 March 5, 2025 13:41
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

Please wrap lines to 80 characters (or 88 given that's what Black prefers) given the LLVM coding standards.

Keenuts added 5 commits March 7, 2025 11:16
The current container focuses on Github metrics. Before
deprecating BuildKite, we want to make sure the new infra
quality is better, or at least the same.

Being able to compare buildkite metrics with github metrics on grafana
will allow us to easily present the comparison.
@Keenuts
Copy link
Contributor Author

Keenuts commented Mar 7, 2025

Overall LGTM.

Please wrap lines to 80 characters (or 88 given that's what Black prefers) given the LLVM coding standards.

done (not strict 80, but around for visibility)

@Keenuts Keenuts requested a review from boomanaiden154 March 7, 2025 10:32
@Keenuts
Copy link
Contributor Author

Keenuts commented Mar 7, 2025

Turns out the issue I had was due to the way we kept track of the last visited workflow.
But It seems it was overly complex for no reason: the workflows are returned sorted, and we can even filter the 'completed' ones at the query level.
Meaning we only need to keep track of one workflow ID: the one we checked.
Logic is not similar to the buildkite version.

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this now also contains changes from #130317? Is the plan to land that first and then rebase?

@Keenuts
Copy link
Contributor Author

Keenuts commented Mar 10, 2025

It looks like this now also contains changes from #130317? Is the plan to land that first and then rebase?

Yes, working on this I realized I needed to rework the github part first, so plan on landing the refactoring PR first, then rework this one to just add the buildkite part.

@Keenuts Keenuts merged commit 3df8be3 into llvm:main Mar 11, 2025
11 checks passed
@Keenuts Keenuts deleted the metrics branch March 11, 2025 13:11
Keenuts added a commit that referenced this pull request Mar 11, 2025
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants