-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[CI] Extend metrics container to log BuildKite metrics #129699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ With the latest revision this PR passed the Python code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, pretty much all just nits. This overall looks pretty good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Please wrap lines to 80 characters (or 88 given that's what Black prefers) given the LLVM coding standards.
The current container focuses on Github metrics. Before deprecating BuildKite, we want to make sure the new infra quality is better, or at least the same. Being able to compare buildkite metrics with github metrics on grafana will allow us to easily present the comparison.
done (not strict 80, but around for visibility) |
Turns out the issue I had was due to the way we kept track of the last visited workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this now also contains changes from #130317? Is the plan to land that first and then rebase?
Yes, working on this I realized I needed to rework the github part first, so plan on landing the refactoring PR first, then rework this one to just add the buildkite part. |
…)" This reverts commit 3df8be3.
…rics" (#130770) Reverts llvm/llvm-project#129699
The current container focuses on Github metrics. Before deprecating BuildKite, we want to make sure the new infra quality is better, or at least the same.
Being able to compare buildkite metrics with github metrics on grafana will allow us to easily present the comparison.
This PR requires llvm/llvm-zorg#400 to be merged first.