Skip to content

[PowerPC] [NFC] Refine PowerPC GISel files according to clang-tidy checks #129780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

MarcusBoay
Copy link
Contributor

Code cleanup for PowerPC GISel files such as renaming header guards and removing unused includes.

Copy link

github-actions bot commented Mar 4, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Mar 4, 2025

@llvm/pr-subscribers-backend-powerpc

Author: Marcus Boay (MarcusBoay)

Changes

Code cleanup for PowerPC GISel files such as renaming header guards and removing unused includes.


Full diff: https://github.com/llvm/llvm-project/pull/129780.diff

3 Files Affected:

  • (modified) llvm/lib/Target/PowerPC/GISel/PPCCallLowering.h (-1)
  • (modified) llvm/lib/Target/PowerPC/GISel/PPCLegalizerInfo.h (+2-2)
  • (modified) llvm/lib/Target/PowerPC/GISel/PPCRegisterBankInfo.h (+2-2)
diff --git a/llvm/lib/Target/PowerPC/GISel/PPCCallLowering.h b/llvm/lib/Target/PowerPC/GISel/PPCCallLowering.h
index 17e8c57e563f8..29b49eb3146f1 100644
--- a/llvm/lib/Target/PowerPC/GISel/PPCCallLowering.h
+++ b/llvm/lib/Target/PowerPC/GISel/PPCCallLowering.h
@@ -16,7 +16,6 @@
 
 #include "PPCISelLowering.h"
 #include "llvm/CodeGen/GlobalISel/CallLowering.h"
-#include "llvm/IR/CallingConv.h"
 
 namespace llvm {
 
diff --git a/llvm/lib/Target/PowerPC/GISel/PPCLegalizerInfo.h b/llvm/lib/Target/PowerPC/GISel/PPCLegalizerInfo.h
index c73186d3d0c11..64be7331514e1 100644
--- a/llvm/lib/Target/PowerPC/GISel/PPCLegalizerInfo.h
+++ b/llvm/lib/Target/PowerPC/GISel/PPCLegalizerInfo.h
@@ -9,8 +9,8 @@
 /// This file declares the targeting of the Machinelegalizer class for PowerPC
 //===----------------------------------------------------------------------===//
 
-#ifndef LLVM_LIB_TARGET_POWERPC_GISEL_PPCMACHINELEGALIZER_H
-#define LLVM_LIB_TARGET_POWERPC_GISEL_PPCMACHINELEGALIZER_H
+#ifndef LLVM_LIB_TARGET_POWERPC_GISEL_PPCLEGALIZERINFO_H
+#define LLVM_LIB_TARGET_POWERPC_GISEL_PPCLEGALIZERINFO_H
 
 #include "llvm/CodeGen/GlobalISel/LegalizerInfo.h"
 
diff --git a/llvm/lib/Target/PowerPC/GISel/PPCRegisterBankInfo.h b/llvm/lib/Target/PowerPC/GISel/PPCRegisterBankInfo.h
index 332a34fe022dd..3d84cd555504a 100644
--- a/llvm/lib/Target/PowerPC/GISel/PPCRegisterBankInfo.h
+++ b/llvm/lib/Target/PowerPC/GISel/PPCRegisterBankInfo.h
@@ -11,8 +11,8 @@
 ///
 //===----------------------------------------------------------------------===//
 
-#ifndef LLVM_LIB_TARGET_PPC_GISEL_PPCREGISTERBANKINFO_H
-#define LLVM_LIB_TARGET_PPC_GISEL_PPCREGISTERBANKINFO_H
+#ifndef LLVM_LIB_TARGET_POWERPC_GISEL_PPCREGISTERBANKINFO_H
+#define LLVM_LIB_TARGET_POWERPC_GISEL_PPCREGISTERBANKINFO_H
 
 #include "llvm/CodeGen/RegisterBank.h"
 #include "llvm/CodeGen/RegisterBankInfo.h"

@redstar redstar requested review from amy-kwan and redstar March 5, 2025 14:35
Copy link
Contributor

@amy-kwan amy-kwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@redstar redstar merged commit 50219c8 into llvm:main Mar 6, 2025
13 checks passed
Copy link

github-actions bot commented Mar 6, 2025

@MarcusBoay Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
…ecks (llvm#129780)

Code cleanup for PowerPC GISel files such as renaming header guards and
removing unused includes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants