[mlir][tosa] Update RFFT2D description to align with TOSA v1.0 spec #129789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align description with the TOSA v1.0 specification Change-Id: Ic36dbe369f430267462081e8cba866687c2ff4ed Signed-off-by: Luke Hutton <[email protected]>
|
@llvm/pr-subscribers-mlir Author: Jerry-Ge (Jerry-Ge) ChangesAlign description with the TOSA v1.0 specification: https://www.mlplatform.org/tosa/tosa_spec.html#_rfft2d Full diff: https://github.com/llvm/llvm-project/pull/129789.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index e0f2fd411bbe4..086d882d76da2 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -372,8 +372,10 @@ def Tosa_RFFT2dOp : Tosa_InferShapedTypeOp<"rfft2d", [
the input tensor consists of real values producing complex valued output. The
complex output values will be split into the output_real and output_imag
tensor arguments. RFFT2D takes advantage of Hermitian symmetry to only
- calculate the first half of the final output axis. Imaginary values with
- locations (0,0), (0,W/2), (H/2,0) and (H/2,W/2) are zero.
+ calculate the first half of the final output axis. Implementations may choose
+ to skip calculation of the imaginary values at (0,0), (0,W/2), (H/2,0), and
+ (H/2, W/2). If the calculation is skipped, the result at that location must be
+ zero.
Example:
|
|
@llvm/pr-subscribers-mlir-tosa Author: Jerry-Ge (Jerry-Ge) ChangesAlign description with the TOSA v1.0 specification: https://www.mlplatform.org/tosa/tosa_spec.html#_rfft2d Full diff: https://github.com/llvm/llvm-project/pull/129789.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index e0f2fd411bbe4..086d882d76da2 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -372,8 +372,10 @@ def Tosa_RFFT2dOp : Tosa_InferShapedTypeOp<"rfft2d", [
the input tensor consists of real values producing complex valued output. The
complex output values will be split into the output_real and output_imag
tensor arguments. RFFT2D takes advantage of Hermitian symmetry to only
- calculate the first half of the final output axis. Imaginary values with
- locations (0,0), (0,W/2), (H/2,0) and (H/2,W/2) are zero.
+ calculate the first half of the final output axis. Implementations may choose
+ to skip calculation of the imaginary values at (0,0), (0,W/2), (H/2,0), and
+ (H/2, W/2). If the calculation is skipped, the result at that location must be
+ zero.
Example:
|
GeorgeARM
approved these changes
Mar 5, 2025
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align description with the TOSA v1.0 specification: https://www.mlplatform.org/tosa/tosa_spec.html#_rfft2d