Skip to content

[LoongArch] Relax the restrictions of inlineasm operand modifier 'u' and 'w' #129864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/docs/LangRef.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5814,6 +5814,8 @@ Hexagon:

LoongArch:

- ``u``: Print an LASX register.
- ``w``: Print an LSX register.
- ``z``: Print $zero register if operand is zero, otherwise print it normally.

MSP430:
Expand Down
35 changes: 22 additions & 13 deletions llvm/lib/Target/LoongArch/LoongArchAsmPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,20 +90,29 @@ bool LoongArchAsmPrinter::PrintAsmOperand(const MachineInstr *MI, unsigned OpNo,
return false;
}
break;
case 'w': // Print LSX registers.
if (MO.getReg().id() >= LoongArch::VR0 &&
MO.getReg().id() <= LoongArch::VR31)
break;
// The modifier is 'w' but the operand is not an LSX register; Report an
// unknown operand error.
return true;
case 'u': // Print LASX registers.
if (MO.getReg().id() >= LoongArch::XR0 &&
MO.getReg().id() <= LoongArch::XR31)
break;
// The modifier is 'u' but the operand is not an LASX register; Report an
// unknown operand error.
return true;
case 'w': // Print LSX registers.
{
// If the operand is an LASX, LSX or floating point register, print the
// name of LASX or LSX register with the same index in that register
// class.
unsigned RegID = MO.getReg().id(), FirstReg;
if (RegID >= LoongArch::XR0 && RegID <= LoongArch::XR31)
FirstReg = LoongArch::XR0;
else if (RegID >= LoongArch::VR0 && RegID <= LoongArch::VR31)
FirstReg = LoongArch::VR0;
else if (RegID >= LoongArch::F0_64 && RegID <= LoongArch::F31_64)
FirstReg = LoongArch::F0_64;
else if (RegID >= LoongArch::F0 && RegID <= LoongArch::F31)
FirstReg = LoongArch::F0;
else
return true;
OS << '$'
<< LoongArchInstPrinter::getRegisterName(
RegID - FirstReg +
(ExtraCode[0] == 'u' ? LoongArch::XR0 : LoongArch::VR0));
return false;
}
// TODO: handle other extra codes if any.
}
}
Expand Down
40 changes: 40 additions & 0 deletions llvm/test/CodeGen/LoongArch/lasx/inline-asm-operand-modifier.ll
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,43 @@ entry:
%0 = tail call <4 x i64> asm sideeffect "xvldi ${0:u}, 1", "=f"()
ret void
}

define void @test_u_2xi64() nounwind {
; CHECK-LABEL: test_u_2xi64:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: #APP
; CHECK-NEXT: xvldi $xr0, 1
; CHECK-NEXT: #NO_APP
; CHECK-NEXT: ret
entry:
%0 = tail call <2 x i64> asm sideeffect "xvldi ${0:u}, 1", "=f"()
ret void
}

define void @test_w_4xi64() nounwind {
; CHECK-LABEL: test_w_4xi64:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: #APP
; CHECK-NEXT: vldi $vr0, 1
; CHECK-NEXT: #NO_APP
; CHECK-NEXT: ret
entry:
%0 = tail call <4 x i64> asm sideeffect "vldi ${0:w}, 1", "=f"()
ret void
}

define void @m128i_to_m256i(ptr %out, ptr %in) nounwind {
; CHECK-LABEL: m128i_to_m256i:
; CHECK: # %bb.0:
; CHECK-NEXT: vld $vr0, $a1, 0
; CHECK-NEXT: xvrepli.b $xr1, 0
; CHECK-NEXT: #APP
; CHECK-NEXT: xvpermi.q $xr1, $xr0, 32
; CHECK-NEXT: #NO_APP
; CHECK-NEXT: xvst $xr1, $a0, 0
; CHECK-NEXT: ret
%v = load <2 x i64>, ptr %in
%x = call <4 x i64> asm sideeffect "xvpermi.q ${0:u}, ${1:u}, 32", "=f,f,0"(<2 x i64> %v, <4 x i64> zeroinitializer)
store <4 x i64> %x, ptr %out
ret void
}