Skip to content

[libc] Allow building the GPU targets that don't have CRT #129945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

jhuber6
Copy link
Contributor

@jhuber6 jhuber6 commented Mar 5, 2025

Summary:
If there's no subdirectory we can't make an alias. This allows it to at
least continue.

Summary:
If there's no subdirectory we can't make an alias. This allows it to at
least continue.
@llvmbot
Copy link
Member

llvmbot commented Mar 5, 2025

@llvm/pr-subscribers-libc

Author: Joseph Huber (jhuber6)

Changes

Summary:
If there's no subdirectory we can't make an alias. This allows it to at
least continue.


Full diff: https://github.com/llvm/llvm-project/pull/129945.diff

1 Files Affected:

  • (modified) libc/startup/gpu/CMakeLists.txt (+3)
diff --git a/libc/startup/gpu/CMakeLists.txt b/libc/startup/gpu/CMakeLists.txt
index 9d0e0885dff93..fa326ef46a9d1 100644
--- a/libc/startup/gpu/CMakeLists.txt
+++ b/libc/startup/gpu/CMakeLists.txt
@@ -40,6 +40,9 @@ endfunction()
 
 if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/${LIBC_TARGET_ARCHITECTURE})
   add_subdirectory(${LIBC_TARGET_ARCHITECTURE})
+else()
+  message(WARNING "Cannot build 'crt1.o' for ${LIBC_TARGET_ARCHITECTURE} yet.")
+  return()
 endif()
 
 add_startup_object(

@jhuber6 jhuber6 merged commit 77363f7 into llvm:main Mar 5, 2025
18 checks passed
@jhuber6 jhuber6 deleted the GPUCRT branch March 5, 2025 22:39
jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
Summary:
If there's no subdirectory we can't make an alias. This allows it to at
least continue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants