-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[OpenMPIRBuilder] Introduce OMPRegionInfo managing the stack of OpenMP region constructs. #130135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Meinersbur
wants to merge
52
commits into
users/meinersbur/irbuilder-extract
Choose a base branch
from
users/meinersbur/irbuilder-ompregion
base: users/meinersbur/irbuilder-extract
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[OpenMPIRBuilder] Introduce OMPRegionInfo managing the stack of OpenMP region constructs. #130135
Meinersbur
wants to merge
52
commits into
users/meinersbur/irbuilder-extract
from
users/meinersbur/irbuilder-ompregion
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current OpenMPIRBuilder currently fails misrable with anything that causes control flow to jump out of an outlined region:
This patch introduces a stack of OMPRegionInfo objects that keeps track of which OpenMP (outlined or non-outlined) region we are currently in, and handles control flow escaping this region.
RegionStack replaces FinalizationStack with a more idiomatic modeling of every region instead of only those that have a finalization callback. It can be though as a continuation of D118409, and fixes the following problems:
PR Stack:
Originally submitted as https://reviews.llvm.org/D124823