[EquivClasses] Fix signature of copy-assignment operator #130140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-adt Author: Ramkumar Ramachandra (artagnon) ChangesFull diff: https://github.com/llvm/llvm-project/pull/130140.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/EquivalenceClasses.h b/llvm/include/llvm/ADT/EquivalenceClasses.h
index 4f98b84cf97d2..c375d6e77b12a 100644
--- a/llvm/include/llvm/ADT/EquivalenceClasses.h
+++ b/llvm/include/llvm/ADT/EquivalenceClasses.h
@@ -144,7 +144,7 @@ class EquivalenceClasses {
operator=(RHS);
}
- const EquivalenceClasses &operator=(const EquivalenceClasses &RHS) {
+ EquivalenceClasses &operator=(const EquivalenceClasses &RHS) {
TheMapping.clear();
for (iterator I = RHS.begin(), E = RHS.end(); I != E; ++I)
if (I->isLeader()) {
|
david-arm
reviewed
Mar 6, 2025
The current signature is incorrect per the C++ operator overloading spec. https://en.cppreference.com/w/cpp/language/operators Also added to description. |
fhahn
reviewed
Mar 6, 2025
There was a problem hiding this comment.
I might be missing something, but as per my reading of https://en.cppreference.com/w/cpp/language/copy_assignment the current definition should be ok?
nikic
approved these changes
Mar 6, 2025
kuhar
approved these changes
Mar 6, 2025
Sounds good to me, but please update the commit message |
|
I'd expect coverage for this in the unit tests? |
The patch is a NFC. |
NFC in the sense that it doesn't change the behavior of any LLVM programs, but we generally treat NFC a bit differently when it comes to ADTs or anything that's similarly/more unit testable. In which case we mostly test anything that can be observed on the API surface area. And this can be observed and tested. Potentially modifying the existing unit test (assuming this function has existing unit test coverage, if not, it should be added) to initialize a non-const ref from the result of the assignment (& existing test coverage should be checking that resulting reference has the same address as the object) |
artagnon
changed the title
Fixed, thanks. |
artagnon
changed the title
dwblaikie
approved these changes
Mar 7, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/155/builds/7303 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/8118 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/85/builds/6279 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/193/builds/6150 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current signature is unusual, and deviates from the C++ operator overloading spec.
https://en.cppreference.com/w/cpp/language/copy_assignment