Skip to content

Optionally print !prof metadata inline #130303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Optionally print !prof metadata inline #130303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions llvm/lib/IR/AsmWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ static cl::opt<bool> PrintInstDebugLocs(
"print-inst-debug-locs", cl::Hidden,
cl::desc("Pretty print debug locations of instructions when dumping"));

static cl::opt<bool> PrintProfData(
"print-prof-data", cl::Hidden,
cl::desc("Pretty print perf data (branch weights, etc) when dumping"));

// Make virtual table appear in this compilation unit.
AssemblyAnnotationWriter::~AssemblyAnnotationWriter() = default;

Expand Down Expand Up @@ -4161,6 +4165,13 @@ void AssemblyWriter::printFunction(const Function *F) {
writeOperand(F->getPersonalityFn(), /*PrintType=*/true);
}

if (PrintProfData) {
if (auto *MDProf = F->getMetadata(LLVMContext::MD_prof)) {
Out << " ";
MDProf->print(Out, TheModule, /*IsForDebug=*/true);
}
}

if (F->isDeclaration()) {
Out << '\n';
} else {
Expand Down Expand Up @@ -4287,6 +4298,14 @@ void AssemblyWriter::printInfoComment(const Value &V) {
}
}
}
if (PrintProfData) {
if (auto *I = dyn_cast<Instruction>(&V)) {
if (auto *MD = I->getMetadata(LLVMContext::MD_prof)) {
Out << " ; ";
MD->print(Out, TheModule, /*IsForDebug=*/true);
}
}
}

if (PrintInstAddrs)
Out << " ; " << &V;
Expand Down
24 changes: 24 additions & 0 deletions llvm/test/Other/print-prof-data.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
; RUN: opt %s -print-prof-data -S | FileCheck %s

define void @foo(ptr %p) !prof !0 {
%isnull = icmp eq ptr %p, null
br i1 %isnull, label %yes, label %no, !prof !1
yes:
%something = select i1 %isnull, i32 1, i32 2, !prof !2
br label %exit
no:
call void %p(), !prof !3
br label %exit
exit:
ret void
}

!0 = !{!"function_entry_count", i64 42}
!1 = !{!"branch_weights", i64 20, i64 101}
!2 = !{!"branch_weights", i64 5, i64 70}
!3 = !{!"VP", i32 0, i64 4, i64 4445083295448962937, i64 2, i64 -2718743882639408571, i64 2}

; CHECK: define void @foo(ptr %p) !0 = !{!"function_entry_count", i64 42} !prof !0 {
; CHECK: br i1 %isnull, label %yes, label %no, !prof !1 ; !1 = !{!"branch_weights", i64 20, i64 101}
; CHECK: %something = select i1 %isnull, i32 1, i32 2, !prof !2 ; !2 = !{!"branch_weights", i64 5, i64 70}
; CHECK: call void %p(), !prof !3 ; !3 = !{!"VP", i32 0, i64 4, i64 4445083295448962937, i64 2, i64 -2718743882639408571, i64 2}
Loading