[AArch64][ELF Parser] Fix out-of-scope variable usage

[sivan-shani]

Return a reference to a persistent variable instead of a temporary copy.

[llvmbot]

@llvm/pr-subscribers-llvm-support

Author: SivanShani-Arm (sivan-shani)

Changes

Return a reference to a persistent variable instead of a temporary copy.

---

Full diff: https://github.com/llvm/llvm-project/pull/130576.diff

1 Files Affected:

• (modified) llvm/lib/Support/ELFAttrParserExtended.cpp (+2-2)

diff --git a/llvm/lib/Support/ELFAttrParserExtended.cpp b/llvm/lib/Support/ELFAttrParserExtended.cpp
index 44f86a38ef8c2..f8a6f46360dec 100644
--- a/llvm/lib/Support/ELFAttrParserExtended.cpp
+++ b/llvm/lib/Support/ELFAttrParserExtended.cpp
@@ -32,9 +32,9 @@ ELFExtendedAttrParser::getAttributeValue(unsigned Tag) const {
 std::optional<unsigned>
 ELFExtendedAttrParser::getAttributeValue(StringRef BuildAttrSubsectionName,
                                          unsigned Tag) const {
-  for (auto SubSection : SubSectionVec) {
+  for (const auto &SubSection : SubSectionVec) {
     if (BuildAttrSubsectionName == SubSection.Name)
-      for (auto BAItem : SubSection.Content) {
+      for (const auto &BAItem : SubSection.Content) {
         if (Tag == BAItem.Tag)
           return std::optional<unsigned>(BAItem.IntValue);
       }

[sivan-shani]

This is a fix for failing sanitizers on commit:
b1ebfac

failing sanitizers:
https://lab.llvm.org/buildbot/#/builders/51/builds/12245

[eleanor-arm]

LGTM