Skip to content

[LLVM][Maintainers] Add llvm-cov / Coverage maintainer #130590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Mar 10, 2025

I think @chapuni has been the most active in this area recently (mostly related to MC/DC). Would you be willing to be listed as the maintainer for this component?

@nikic nikic requested a review from chapuni March 10, 2025 12:08
Copy link
Contributor

@chapuni chapuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I can accept. Thanks for the nomination.

That said, I am still a reviewee with bunch of unapproved request. I'd really like more a few maintainers in this area.

@nikic
Copy link
Contributor Author

nikic commented Mar 18, 2025

That said, I am still a reviewee with bunch of unapproved request. I'd really like more a few maintainers in this area.

More maintainers is always better :) Do you have any suggestions for other coverage maintainers?

@chapuni
Copy link
Contributor

chapuni commented Mar 18, 2025

I'd like to nominate @evodius96 and @MaskRay , or to let them nominate others.
I know they are busy.

@MaskRay
Copy link
Member

MaskRay commented Mar 20, 2025

I'd like to nominate @evodius96 and @MaskRay , or to let them nominate others. I know they are busy.

I’d like to nominate evodius96 as well, if he’s willing to accept... I’d prefer not to be included myself, as I’m currently juggling other responsibilities. I hope I can help when I find some free time.
(Apologies for not reviewing your coverage patches recently—I’ve been swamped with my day job and a surge of linker-related work. (I thought lld was pretty stable, but lately there’s been GNU_PROPERTY from RISC-V and AArch64, a bunch of new AArch64 options, linker relaxation stuff for RISC-V and LoongArch, --icf=all, --why-live...))

@evodius96
Copy link
Contributor

I accept the nomination; though it helps to know there are other maintainers. Thanks!

@nikic nikic force-pushed the coverage-maintainer branch from 27b3c2b to 5714e16 Compare April 2, 2025 10:48
@nikic
Copy link
Contributor Author

nikic commented Apr 2, 2025

Sorry for the delay here, I've now added @evodius96 as well.

@nikic nikic merged commit 6d992f1 into llvm:main Apr 11, 2025
11 checks passed
@nikic nikic deleted the coverage-maintainer branch April 11, 2025 09:31

Takumi Nakamura \
[email protected] (email), [chapuni](https://github.com/chapuni) (GitHub) \
Alan Philipps \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit: last name is spelled "Phipps".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, should be fixed in c3795ba.

var-const pushed a commit to ldionne/llvm-project that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants