Skip to content

[NFC][AMDGPU] Auto generate check lines for some assembler tests #130797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

[NFC][AMDGPU] Auto generate check lines for some assembler tests #130797

merged 1 commit into from
Mar 11, 2025

Conversation

shiltian
Copy link
Contributor

No description provided.

@llvmbot llvmbot added backend:AMDGPU mc Machine (object) code labels Mar 11, 2025
@shiltian Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@llvmbot
Copy link
Member

llvmbot commented Mar 11, 2025 •
edited
Loading

@llvm/pr-subscribers-mc

@llvm/pr-subscribers-backend-amdgpu

Author: Shilei Tian (shiltian)

Changes

Patch is 679.21 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/130797.diff

3 Files Affected:

  • (modified) llvm/test/MC/AMDGPU/gfx12_asm_sop1.s (+1424-1423)
  • (modified) llvm/test/MC/AMDGPU/gfx12_asm_sop2.s (+2099-2096)
  • (modified) llvm/test/MC/AMDGPU/gfx12_asm_sopc.s (+721-720)
diff --git a/llvm/test/MC/AMDGPU/gfx12_asm_sop1.s b/llvm/test/MC/AMDGPU/gfx12_asm_sop1.s
index 51fd7ded8fda7..55322878de85b 100644
--- a/llvm/test/MC/AMDGPU/gfx12_asm_sop1.s
+++ b/llvm/test/MC/AMDGPU/gfx12_asm_sop1.s
@@ -1,4270 +1,4271 @@
+// NOTE: Assertions have been autogenerated by utils/update_mc_test_checks.py UTC_ARGS: --version 5
 // RUN: llvm-mc -triple=amdgcn -show-encoding -mcpu=gfx1200 %s | FileCheck --check-prefix=GFX12 %s
 
 s_alloc_vgpr 0x1235
-// GFX12: encoding: [0xff,0x53,0x80,0xbe,0x35,0x12,0x00,0x00]
+// GFX12: s_alloc_vgpr 0x1235                     ; encoding: [0xff,0x53,0x80,0xbe,0x35,0x12,0x00,0x00]
 
 s_alloc_vgpr 18
-// GFX12: encoding: [0x92,0x53,0x80,0xbe]
+// GFX12: s_alloc_vgpr 18                         ; encoding: [0x92,0x53,0x80,0xbe]
 
 s_alloc_vgpr s35
-// GFX12: encoding: [0x23,0x53,0x80,0xbe]
+// GFX12: s_alloc_vgpr s35                        ; encoding: [0x23,0x53,0x80,0xbe]
 
 s_alloc_vgpr m0
-// GFX12: encoding: [0x7d,0x53,0x80,0xbe]
+// GFX12: s_alloc_vgpr m0                         ; encoding: [0x7d,0x53,0x80,0xbe]
 
 s_alloc_vgpr scc
-// GFX12: encoding: [0xfd,0x53,0x80,0xbe]
+// GFX12: s_alloc_vgpr src_scc                    ; encoding: [0xfd,0x53,0x80,0xbe]
 
 s_sleep_var 0x1234
-// GFX12: encoding: [0xff,0x58,0x80,0xbe,0x34,0x12,0x00,0x00]
+// GFX12: s_sleep_var 0x1234                      ; encoding: [0xff,0x58,0x80,0xbe,0x34,0x12,0x00,0x00]
 
 s_sleep_var s1
-// GFX12: encoding: [0x01,0x58,0x80,0xbe]
+// GFX12: s_sleep_var s1                          ; encoding: [0x01,0x58,0x80,0xbe]
 
 s_cvt_f32_i32 s5, s1
-// GFX12: encoding: [0x01,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, s1                    ; encoding: [0x01,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s105, s1
-// GFX12: encoding: [0x01,0x64,0xe9,0xbe]
+// GFX12: s_cvt_f32_i32 s105, s1                  ; encoding: [0x01,0x64,0xe9,0xbe]
 
 s_cvt_f32_i32 s5, s105
-// GFX12: encoding: [0x69,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, s105                  ; encoding: [0x69,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, s103
-// GFX12: encoding: [0x67,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, s103                  ; encoding: [0x67,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, vcc_lo
-// GFX12: encoding: [0x6a,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, vcc_lo                ; encoding: [0x6a,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, vcc_hi
-// GFX12: encoding: [0x6b,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, vcc_hi                ; encoding: [0x6b,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, ttmp11
-// GFX12: encoding: [0x77,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, ttmp11                ; encoding: [0x77,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, m0
-// GFX12: encoding: [0x7d,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, m0                    ; encoding: [0x7d,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, exec_lo
-// GFX12: encoding: [0x7e,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, exec_lo               ; encoding: [0x7e,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, exec_hi
-// GFX12: encoding: [0x7f,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, exec_hi               ; encoding: [0x7f,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, 0
-// GFX12: encoding: [0x80,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, 0                     ; encoding: [0x80,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, -1
-// GFX12: encoding: [0xc1,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, -1                    ; encoding: [0xc1,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, 0.5
-// GFX12: encoding: [0xf0,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, 0.5                   ; encoding: [0xf0,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, -4.0
-// GFX12: encoding: [0xf7,0x64,0x85,0xbe]
+// GFX12: s_cvt_f32_i32 s5, -4.0                  ; encoding: [0xf7,0x64,0x85,0xbe]
 
 s_cvt_f32_i32 s5, 0xaf123456
-// GFX12: encoding: [0xff,0x64,0x85,0xbe,0x56,0x34,0x12,0xaf]
+// GFX12: s_cvt_f32_i32 s5, 0xaf123456            ; encoding: [0xff,0x64,0x85,0xbe,0x56,0x34,0x12,0xaf]
 
 s_cvt_f32_i32 s5, 0x3f717273
-// GFX12: encoding: [0xff,0x64,0x85,0xbe,0x73,0x72,0x71,0x3f]
+// GFX12: s_cvt_f32_i32 s5, 0x3f717273            ; encoding: [0xff,0x64,0x85,0xbe,0x73,0x72,0x71,0x3f]
 
 s_cvt_f32_u32 s5, s1
-// GFX12: encoding: [0x01,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, s1                    ; encoding: [0x01,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s105, s1
-// GFX12: encoding: [0x01,0x65,0xe9,0xbe]
+// GFX12: s_cvt_f32_u32 s105, s1                  ; encoding: [0x01,0x65,0xe9,0xbe]
 
 s_cvt_f32_u32 s5, s105
-// GFX12: encoding: [0x69,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, s105                  ; encoding: [0x69,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, s103
-// GFX12: encoding: [0x67,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, s103                  ; encoding: [0x67,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, vcc_lo
-// GFX12: encoding: [0x6a,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, vcc_lo                ; encoding: [0x6a,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, vcc_hi
-// GFX12: encoding: [0x6b,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, vcc_hi                ; encoding: [0x6b,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, ttmp11
-// GFX12: encoding: [0x77,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, ttmp11                ; encoding: [0x77,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, m0
-// GFX12: encoding: [0x7d,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, m0                    ; encoding: [0x7d,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, exec_lo
-// GFX12: encoding: [0x7e,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, exec_lo               ; encoding: [0x7e,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, exec_hi
-// GFX12: encoding: [0x7f,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, exec_hi               ; encoding: [0x7f,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, 0
-// GFX12: encoding: [0x80,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, 0                     ; encoding: [0x80,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, -1
-// GFX12: encoding: [0xc1,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, -1                    ; encoding: [0xc1,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, 0.5
-// GFX12: encoding: [0xf0,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, 0.5                   ; encoding: [0xf0,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, -4.0
-// GFX12: encoding: [0xf7,0x65,0x85,0xbe]
+// GFX12: s_cvt_f32_u32 s5, -4.0                  ; encoding: [0xf7,0x65,0x85,0xbe]
 
 s_cvt_f32_u32 s5, 0xaf123456
-// GFX12: encoding: [0xff,0x65,0x85,0xbe,0x56,0x34,0x12,0xaf]
+// GFX12: s_cvt_f32_u32 s5, 0xaf123456            ; encoding: [0xff,0x65,0x85,0xbe,0x56,0x34,0x12,0xaf]
 
 s_cvt_f32_u32 s5, 0x3f717273
-// GFX12: encoding: [0xff,0x65,0x85,0xbe,0x73,0x72,0x71,0x3f]
+// GFX12: s_cvt_f32_u32 s5, 0x3f717273            ; encoding: [0xff,0x65,0x85,0xbe,0x73,0x72,0x71,0x3f]
 
 s_cvt_u32_f32 s5, s1
-// GFX12: encoding: [0x01,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, s1                    ; encoding: [0x01,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s105, s1
-// GFX12: encoding: [0x01,0x67,0xe9,0xbe]
+// GFX12: s_cvt_u32_f32 s105, s1                  ; encoding: [0x01,0x67,0xe9,0xbe]
 
 s_cvt_u32_f32 s5, s105
-// GFX12: encoding: [0x69,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, s105                  ; encoding: [0x69,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, s103
-// GFX12: encoding: [0x67,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, s103                  ; encoding: [0x67,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, vcc_lo
-// GFX12: encoding: [0x6a,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, vcc_lo                ; encoding: [0x6a,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, vcc_hi
-// GFX12: encoding: [0x6b,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, vcc_hi                ; encoding: [0x6b,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, ttmp11
-// GFX12: encoding: [0x77,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, ttmp11                ; encoding: [0x77,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, m0
-// GFX12: encoding: [0x7d,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, m0                    ; encoding: [0x7d,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, exec_lo
-// GFX12: encoding: [0x7e,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, exec_lo               ; encoding: [0x7e,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, exec_hi
-// GFX12: encoding: [0x7f,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, exec_hi               ; encoding: [0x7f,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, 0
-// GFX12: encoding: [0x80,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, 0                     ; encoding: [0x80,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, -1
-// GFX12: encoding: [0xc1,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, -1                    ; encoding: [0xc1,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, 0.5
-// GFX12: encoding: [0xf0,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, 0.5                   ; encoding: [0xf0,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, -4.0
-// GFX12: encoding: [0xf7,0x67,0x85,0xbe]
+// GFX12: s_cvt_u32_f32 s5, -4.0                  ; encoding: [0xf7,0x67,0x85,0xbe]
 
 s_cvt_u32_f32 s5, 0xaf123456
-// GFX12: encoding: [0xff,0x67,0x85,0xbe,0x56,0x34,0x12,0xaf]
+// GFX12: s_cvt_u32_f32 s5, 0xaf123456            ; encoding: [0xff,0x67,0x85,0xbe,0x56,0x34,0x12,0xaf]
 
 s_cvt_u32_f32 s5, 0x3f717273
-// GFX12: encoding: [0xff,0x67,0x85,0xbe,0x73,0x72,0x71,0x3f]
+// GFX12: s_cvt_u32_f32 s5, 0x3f717273            ; encoding: [0xff,0x67,0x85,0xbe,0x73,0x72,0x71,0x3f]
 
 s_cvt_i32_f32 s5, s1
-// GFX12: encoding: [0x01,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, s1                    ; encoding: [0x01,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s105, s1
-// GFX12: encoding: [0x01,0x66,0xe9,0xbe]
+// GFX12: s_cvt_i32_f32 s105, s1                  ; encoding: [0x01,0x66,0xe9,0xbe]
 
 s_cvt_i32_f32 s5, s105
-// GFX12: encoding: [0x69,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, s105                  ; encoding: [0x69,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, s103
-// GFX12: encoding: [0x67,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, s103                  ; encoding: [0x67,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, vcc_lo
-// GFX12: encoding: [0x6a,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, vcc_lo                ; encoding: [0x6a,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, vcc_hi
-// GFX12: encoding: [0x6b,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, vcc_hi                ; encoding: [0x6b,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, ttmp11
-// GFX12: encoding: [0x77,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, ttmp11                ; encoding: [0x77,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, m0
-// GFX12: encoding: [0x7d,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, m0                    ; encoding: [0x7d,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, exec_lo
-// GFX12: encoding: [0x7e,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, exec_lo               ; encoding: [0x7e,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, exec_hi
-// GFX12: encoding: [0x7f,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, exec_hi               ; encoding: [0x7f,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, 0
-// GFX12: encoding: [0x80,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, 0                     ; encoding: [0x80,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, -1
-// GFX12: encoding: [0xc1,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, -1                    ; encoding: [0xc1,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, 0.5
-// GFX12: encoding: [0xf0,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, 0.5                   ; encoding: [0xf0,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, -4.0
-// GFX12: encoding: [0xf7,0x66,0x85,0xbe]
+// GFX12: s_cvt_i32_f32 s5, -4.0                  ; encoding: [0xf7,0x66,0x85,0xbe]
 
 s_cvt_i32_f32 s5, 0xaf123456
-// GFX12: encoding: [0xff,0x66,0x85,0xbe,0x56,0x34,0x12,0xaf]
+// GFX12: s_cvt_i32_f32 s5, 0xaf123456            ; encoding: [0xff,0x66,0x85,0xbe,0x56,0x34,0x12,0xaf]
 
 s_cvt_i32_f32 s5, 0x3f717273
-// GFX12: encoding: [0xff,0x66,0x85,0xbe,0x73,0x72,0x71,0x3f]
+// GFX12: s_cvt_i32_f32 s5, 0x3f717273            ; encoding: [0xff,0x66,0x85,0xbe,0x73,0x72,0x71,0x3f]
 
 s_cvt_f16_f32 s5, s1
-// GFX12: encoding: [0x01,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, s1                    ; encoding: [0x01,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s105, s1
-// GFX12: encoding: [0x01,0x68,0xe9,0xbe]
+// GFX12: s_cvt_f16_f32 s105, s1                  ; encoding: [0x01,0x68,0xe9,0xbe]
 
 s_cvt_f16_f32 s5, s105
-// GFX12: encoding: [0x69,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, s105                  ; encoding: [0x69,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, s103
-// GFX12: encoding: [0x67,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, s103                  ; encoding: [0x67,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, vcc_lo
-// GFX12: encoding: [0x6a,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, vcc_lo                ; encoding: [0x6a,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, vcc_hi
-// GFX12: encoding: [0x6b,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, vcc_hi                ; encoding: [0x6b,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, ttmp11
-// GFX12: encoding: [0x77,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, ttmp11                ; encoding: [0x77,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, m0
-// GFX12: encoding: [0x7d,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, m0                    ; encoding: [0x7d,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, exec_lo
-// GFX12: encoding: [0x7e,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, exec_lo               ; encoding: [0x7e,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, exec_hi
-// GFX12: encoding: [0x7f,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, exec_hi               ; encoding: [0x7f,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, 0
-// GFX12: encoding: [0x80,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, 0                     ; encoding: [0x80,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, -1
-// GFX12: encoding: [0xc1,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, -1                    ; encoding: [0xc1,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, 0.5
-// GFX12: encoding: [0xf0,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, 0.5                   ; encoding: [0xf0,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, -4.0
-// GFX12: encoding: [0xf7,0x68,0x85,0xbe]
+// GFX12: s_cvt_f16_f32 s5, -4.0                  ; encoding: [0xf7,0x68,0x85,0xbe]
 
 s_cvt_f16_f32 s5, 0xaf123456
-// GFX12: encoding: [0xff,0x68,0x85,0xbe,0x56,0x34,0x12,0xaf]
+// GFX12: s_cvt_f16_f32 s5, 0xaf123456            ; encoding: [0xff,0x68,0x85,0xbe,0x56,0x34,0x12,0xaf]
 
 s_cvt_f16_f32 s5, 0x3f717273
-// GFX12: encoding: [0xff,0x68,0x85,0xbe,0x73,0x72,0x71,0x3f]
+// GFX12: s_cvt_f16_f32 s5, 0x3f717273            ; encoding: [0xff,0x68,0x85,0xbe,0x73,0x72,0x71,0x3f]
 
 s_cvt_f32_f16 s5, s1
-// GFX12: encoding: [0x01,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, s1                    ; encoding: [0x01,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s105, s1
-// GFX12: encoding: [0x01,0x69,0xe9,0xbe]
+// GFX12: s_cvt_f32_f16 s105, s1                  ; encoding: [0x01,0x69,0xe9,0xbe]
 
 s_cvt_f32_f16 s5, s105
-// GFX12: encoding: [0x69,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, s105                  ; encoding: [0x69,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s5, s103
-// GFX12: encoding: [0x67,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, s103                  ; encoding: [0x67,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s5, vcc_lo
-// GFX12: encoding: [0x6a,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, vcc_lo                ; encoding: [0x6a,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s5, vcc_hi
-// GFX12: encoding: [0x6b,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, vcc_hi                ; encoding: [0x6b,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s5, ttmp11
-// GFX12: encoding: [0x77,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, ttmp11                ; encoding: [0x77,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s5, m0
-// GFX12: encoding: [0x7d,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, m0                    ; encoding: [0x7d,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s5, exec_lo
-// GFX12: encoding: [0x7e,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, exec_lo               ; encoding: [0x7e,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s5, exec_hi
-// GFX12: encoding: [0x7f,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, exec_hi               ; encoding: [0x7f,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s5, 0
-// GFX12: encoding: [0x80,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, 0                     ; encoding: [0x80,0x69,0x85,0xbe]
 
 s_cvt_f32_f16 s5, -1
-// GFX12: encoding: [0xc1,0x69,0x85,0xbe]
+// GFX12: s_cvt_f32_f16 s5, -1                    ; encoding: [0xc1,0x69,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, s1
-// GFX12: encoding: [0x01,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, s1                 ; encoding: [0x01,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s105, s1
-// GFX12: encoding: [0x01,0x6a,0xe9,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s105, s1               ; encoding: [0x01,0x6a,0xe9,0xbe]
 
 s_cvt_hi_f32_f16 s5, s105
-// GFX12: encoding: [0x69,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, s105               ; encoding: [0x69,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, s103
-// GFX12: encoding: [0x67,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, s103               ; encoding: [0x67,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, vcc_lo
-// GFX12: encoding: [0x6a,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, vcc_lo             ; encoding: [0x6a,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, vcc_hi
-// GFX12: encoding: [0x6b,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, vcc_hi             ; encoding: [0x6b,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, ttmp11
-// GFX12: encoding: [0x77,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, ttmp11             ; encoding: [0x77,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, m0
-// GFX12: encoding: [0x7d,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, m0                 ; encoding: [0x7d,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, exec_lo
-// GFX12: encoding: [0x7e,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, exec_lo            ; encoding: [0x7e,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, exec_hi
-// GFX12: encoding: [0x7f,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, exec_hi            ; encoding: [0x7f,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, 0
-// GFX12: encoding: [0x80,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, 0                  ; encoding: [0x80,0x6a,0x85,0xbe]
 
 s_cvt_hi_f32_f16 s5, -1
-// GFX12: encoding: [0xc1,0x6a,0x85,0xbe]
+// GFX12: s_cvt_hi_f32_f16 s5, -1                 ; encoding: [0xc1,0x6a,0x85,0xbe]
 
 s_trunc_f32 s5, s1
-// GFX12: encoding: [0x01,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, s1                      ; encoding: [0x01,0x62,0x85,0xbe]
 
 s_trunc_f32 s105, s1
-// GFX12: encoding: [0x01,0x62,0xe9,0xbe]
+// GFX12: s_trunc_f32 s105, s1                    ; encoding: [0x01,0x62,0xe9,0xbe]
 
 s_trunc_f32 s5, s105
-// GFX12: encoding: [0x69,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, s105                    ; encoding: [0x69,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, s103
-// GFX12: encoding: [0x67,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, s103                    ; encoding: [0x67,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, vcc_lo
-// GFX12: encoding: [0x6a,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, vcc_lo                  ; encoding: [0x6a,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, vcc_hi
-// GFX12: encoding: [0x6b,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, vcc_hi                  ; encoding: [0x6b,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, ttmp11
-// GFX12: encoding: [0x77,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, ttmp11                  ; encoding: [0x77,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, m0
-// GFX12: encoding: [0x7d,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, m0                      ; encoding: [0x7d,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, exec_lo
-// GFX12: encoding: [0x7e,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, exec_lo                 ; encoding: [0x7e,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, exec_hi
-// GFX12: encoding: [0x7f,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, exec_hi                 ; encoding: [0x7f,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, 0
-// GFX12: encoding: [0x80,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, 0                       ; encoding: [0x80,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, -1
-// GFX12: encoding: [0xc1,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, -1                      ; encoding: [0xc1,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, 0.5
-// GFX12: encoding: [0xf0,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, 0.5                     ; encoding: [0xf0,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, -4.0
-// GFX12: encoding: [0xf7,0x62,0x85,0xbe]
+// GFX12: s_trunc_f32 s5, -4.0                    ; encoding: [0xf7,0x62,0x85,0xbe]
 
 s_trunc_f32 s5, 0xaf123456
-// GFX12: encoding: [0xff,0x62,0x85,0xbe,0x56,0x34,0x12,0xaf]
+// GFX12: s_trunc_f32 s5, 0xaf123456              ; encoding: [0xff,0x62,0x85,0xbe,0x56,0x34,0x12,0xaf]
 
 s_trunc_f32 s5, 0x3f717273
-// GFX12: encoding: [0xff,0x62,0x85,...
[truncated]

@shiltian shiltian requested review from jayfoad and arsenm March 11, 2025 16:52
jayfoad
jayfoad approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@jayfoad jayfoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'd be in favour of doing this for all AMDGPU asm/dis tests.

@Sisyph
Copy link
Contributor

Sisyph commented Mar 11, 2025

Thanks. I'd be in favour of doing this for all AMDGPU asm/dis tests.

Me too.

Using the auto-generation script AND putting the assembler and disassembler tests in the same file like we have in test/MC/AMDGPU/gfx12_asm_vop1.s would be even better, but it would be a more manual process.

@shiltian shiltian merged commit 3189402 into main Mar 11, 2025
11 of 13 checks passed
@shiltian shiltian deleted the users/shiltian/autogen-check-lines-for-some-assembler-tests branch March 11, 2025 21:04
@shiltian
Copy link
Contributor Author

We could ask anyone touching those code to do an update. FWIW, we don't even have auto generated check lines for all IR tests, though I tried my best to ask folks to do so in the code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayfoad jayfoad jayfoad approved these changes

@arsenm arsenm arsenm approved these changes

Assignees
No one assigned
Labels
backend:AMDGPU mc Machine (object) code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shiltian @llvmbot @Sisyph @jayfoad @arsenm