[NVPTX][test] Use 'not' to switch an XFAIL test to PASS #130839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-nvptx Author: Alex MacLean (AlexMaclean) ChangesUse 'not' to confirm the test has the desired behavior and move it to passing. Full diff: https://github.com/llvm/llvm-project/pull/130839.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/NVPTX/gvar-init.ll b/llvm/test/CodeGen/NVPTX/gvar-init.ll
index 6fd650f7f326c..2c7963fd0a4b5 100644
--- a/llvm/test/CodeGen/NVPTX/gvar-init.ll
+++ b/llvm/test/CodeGen/NVPTX/gvar-init.ll
@@ -1,5 +1,5 @@
-; RUN: llc < %s -mtriple=nvptx -mcpu=sm_20 | FileCheck %s
+; RUN: not --crash llc < %s -mtriple=nvptx -mcpu=sm_20 2>&1 | FileCheck %s
; Error out if initializer is given for address spaces that do not support initializers
-; XFAIL: *
+; CHECK: LLVM ERROR: initial value of 'g0' is not allowed in addrspace(3)
@g0 = addrspace(3) global i32 42
|
Artem-B
approved these changes
Mar 11, 2025
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
Use 'not' to confirm the test has the desired behavior and move it to passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'not' to confirm the test has the desired behavior and move it to passing.