-
Notifications
You must be signed in to change notification settings - Fork 14.2k
[Flang] Add omp_lib dependency to check-flang #130975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjklemm
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/81/builds/5233 Here is the relevant piece of the build log for the reference
|
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
With `LLVM_ENABLE_RUNTIMES=openmp`, flang enables the OpenMP regression tests, but `check-flang` was not ensuring that the OpenMP requirements are built first. Fix by adding a `libomp-mod` to `flang-test-depends`. Adding `libomp-mod` to extra_targets is necessary because there is no target from openmp/ that is reachable from the parent bootstrapping-build. `ninja openmp` fails because openmp/ has no `openmp` target. `check-openmp` would also run the OpenMP tests and does not even build `omp_lib.mod`. `runtimes` would build all the runtimes, not just OpenMP. Also fix the misleading CMake configure status messages that suggest the only way to build omp_lib.mod/.h is `LLVM_ENABLE_PROJECTS=openmp`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
LLVM_ENABLE_RUNTIMES=openmp
, flang enables the OpenMP regression tests, butcheck-flang
was not ensuring that the OpenMP requirements are built first. Fix by adding alibomp-mod
toflang-test-depends
.Adding
libomp-mod
to extra_targets is necessary because there is no target from openmp/ that is reachable from the parent bootstrapping-build.ninja openmp
fails because openmp/ has noopenmp
target.check-openmp
would also run the OpenMP tests and does not even buildomp_lib.mod
.runtimes
would build all the runtimes, not just OpenMP.Also fix the misleading CMake configure status messages that suggest the only way to build omp_lib.mod/.h is
LLVM_ENABLE_PROJECTS=openmp
.