[AMDGPU][CodeGen] use vt in VGPRimm pattern #131016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-amdgpu Author: Brox Chen (broxigarchen) ChangesThere seems to be a typo error introduced by 2033767 Correct this pattern to use vt Full diff: https://github.com/llvm/llvm-project/pull/131016.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/SIInstructions.td b/llvm/lib/Target/AMDGPU/SIInstructions.td
index 985337da1909d..de77401eb0137 100644
--- a/llvm/lib/Target/AMDGPU/SIInstructions.td
+++ b/llvm/lib/Target/AMDGPU/SIInstructions.td
@@ -2268,7 +2268,7 @@ foreach pred = [NotHasTrue16BitInsts, UseFakeTrue16Insts] in {
foreach vt = [f16, bf16] in {
def : GCNPat <
- (VGPRImm<(f16 fpimm)>:$imm),
+ (VGPRImm<(vt fpimm)>:$imm),
(V_MOV_B32_e32 (vt (bitcast_fpimm_to_i32 $imm)))
>;
}
|
arsenm
approved these changes
Mar 13, 2025
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
There seems to be a typo error introduced by llvm@2033767 Correct this pattern to use vt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a typo error introduced by 2033767
Correct this pattern to use vt.