Skip to content

[debugserver] Fix mutex scope in RNBRemote::CommDataReceived #131077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025
Merged

[debugserver] Fix mutex scope in RNBRemote::CommDataReceived #131077

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d27dc4
[debugserver] Fix mutex scope in RNBRemote::CommDataReceived
JDevlieghere Mar 13, 2025
40fd775
Fix indentation
JDevlieghere Mar 13, 2025
05c5ba3
Fix formatting
JDevlieghere Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lldb/tools/debugserver/source/RNBRemote.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@ rnb_err_t RNBRemote::HandleReceivedPacket(PacketEnum *type) {
void RNBRemote::CommDataReceived(const std::string &new_data) {
// DNBLogThreadedIf (LOG_RNB_REMOTE, "%8d RNBRemote::%s called",
// (uint32_t)m_comm.Timer().ElapsedMicroSeconds(true), __FUNCTION__);
{

// Put the packet data into the buffer in a thread safe fashion
PThreadMutex::Locker locker(m_mutex);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you also fix the indentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I don't know why clang-format isn't kicking in...


Expand Down Expand Up @@ -1132,7 +1132,6 @@ void RNBRemote::CommDataReceived(const std::string &new_data) {
__FUNCTION__, data[idx]);
idx = idx + 1;
}
}
}

if (!m_rx_packets.empty()) {
Expand Down