Update the libc BUILD.bazel file with selects for Windows builds. #131172
Conversation
The Windows toolchain needs to build libc targets in order to support libc++. Currently, some targets fail to resolve, due to non-exhaustive select statements, not accounting for Windows builds. This change adds clauses to select statements so that Windows builds can proceed. Additionally, `__support_osutil_exit`, is configured to pass nothing to `srcs` for non-Linux builds. `__support_osutil_exit `is unconditionally included in the transitive dependencies of `extern_libc_shared`.
bashi-bazouk
requested review from
rupprecht,
keith and
aaronmondal
as code owners
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-libc Author: Brian Ledger (bashi-bazouk) ChangesThe Windows toolchain needs to build libc targets in order to support libc++. Currently, some targets fail to resolve, due to non-exhaustive select statements, not accounting for Windows builds. This change adds clauses to select statements so that Windows builds can proceed. Additionally, Full diff: https://github.com/llvm/llvm-project/pull/131172.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 757db65ca8a77..25a9736b3671e 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -1319,6 +1319,7 @@ libc_support_library(
"src/__support/OSUtil/linux/aarch64/syscall.h",
"src/__support/OSUtil/linux/x86_64/syscall.h",
],
+ "@platforms//os:windows": [],
}),
deps = [
":__support_common",
@@ -1360,6 +1361,7 @@ libc_support_library(
textual_hdrs = select({
"@platforms//os:macos": ["src/__support/OSUtil/darwin/io.h"],
"@platforms//os:linux": ["src/__support/OSUtil/linux/io.h"],
+ "@platforms//os:windows": ["src/__support/OSUtil/windows/io.h"],
}),
deps = [
":__support_common",
@@ -1371,7 +1373,10 @@ libc_support_library(
libc_support_library(
name = "__support_osutil_exit",
- srcs = ["src/__support/OSUtil/linux/exit.cpp"],
+ srcs = select({
+ "@platforms//os:linux": ["src/__support/OSUtil/linux/exit.cpp"],
+ "//condition:default": [],
+ }),
hdrs = ["src/__support/OSUtil/exit.h"],
target_compatible_with = select({
"@platforms//os:linux": [],
|
|
@bashi-bazouk Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
…vm#131172) The Windows toolchain needs to build libc targets in order to support libc++. Currently, some targets fail to resolve, due to non-exhaustive select statements, not accounting for Windows builds. This change adds clauses to select statements so that Windows builds can proceed. Additionally, `__support_osutil_exit`, is configured to pass nothing to `srcs` for non-Linux builds. `__support_osutil_exit `is unconditionally included in the transitive dependencies of `extern_libc_shared`. --------- Co-authored-by: Brian Ledger <[email protected]>
The Windows toolchain needs to build libc targets in order to support libc++. Currently, some targets fail to resolve, due to non-exhaustive select statements, not accounting for Windows builds.
This change adds clauses to select statements so that Windows builds can proceed.
Additionally,
__support_osutil_exit, is configured to pass nothing tosrcsfor non-Linux builds.__support_osutil_exitis unconditionally included in the transitive dependencies ofextern_libc_shared.