[GSYM] Fix incorrect comparison in gSYM creation #131197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in
llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
whereStmtSeqVal
was being compared againstUINT32_MAX
rather than the correctUINT64_MAX
- thanks @nocchijiang for pointing this out.We correct the issue with this patch. For testing - the issue would show when we have a correct offset of value
UINT32_MAX
- but constructing such a test is impractical.