Skip to content

[Darwin][ASan][Test] Create a noinlined wrapper function for reliable suppression in test. #131247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025
Merged

[Darwin][ASan][Test] Create a noinlined wrapper function for reliable suppression in test. #131247

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3f7543
[Darwin][ASan][Test] Create a noinlined wrapper function for reliable…
padriff Mar 14, 2025
fcf1cfa
Update compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp
padriff Mar 14, 2025
24b609a
Update compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp
padriff Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// RUN: not %run %t 2>&1 | FileCheck --check-prefix=CHECK-CRASH %s

// Check that suppressing a function name works within a no-fork sandbox
// RUN: echo "interceptor_via_fun:CFStringCreateWithBytes" > %t.supp
// RUN: echo "interceptor_via_fun:createCFString" > %t.supp
// RUN: %env_asan_opts=suppressions='"%t.supp"' \
// RUN: sandbox-exec -p '(version 1)(allow default)(deny process-fork)' \
// RUN: %run %t 2>&1 | FileCheck --check-prefix=CHECK-IGNORE %s
Expand All @@ -13,12 +13,18 @@

#include <CoreFoundation/CoreFoundation.h>

// Disable optimizations to ensure that this function appears on the stack trace so our
// configured suppressions `interceptor_via_fun:createCFString` can take effect.
__attribute__((noinline, disable_tail_calls)) CFStringRef
createCFString(const unsigned char *bytes, CFIndex length) {
return CFStringCreateWithBytes(kCFAllocatorDefault, bytes, length,
kCFStringEncodingUTF8, FALSE);
}

int main() {
char *a = (char *)malloc(6);
strcpy(a, "hello");
CFStringRef str =
CFStringCreateWithBytes(kCFAllocatorDefault, (unsigned char *)a, 10,
kCFStringEncodingUTF8, FALSE); // BOOM
CFStringRef str = createCFString((unsigned char *)a, 10); // BOOM
fprintf(stderr, "Ignored.\n");
free(a);
CFRelease(str);
Expand Down