Skip to content

[Tooling] Avoid repeated hash lookups (NFC) #131264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@kazutakahirata kazutakahirata requested a review from nikic March 14, 2025 03:35
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Mar 14, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 14, 2025

@llvm/pr-subscribers-clang

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/131264.diff

1 Files Affected:

  • (modified) clang/lib/Tooling/RefactoringCallbacks.cpp (+3-2)
diff --git a/clang/lib/Tooling/RefactoringCallbacks.cpp b/clang/lib/Tooling/RefactoringCallbacks.cpp
index e3fc91afeb595..80e78e27434cc 100644
--- a/clang/lib/Tooling/RefactoringCallbacks.cpp
+++ b/clang/lib/Tooling/RefactoringCallbacks.cpp
@@ -220,13 +220,14 @@ void ReplaceNodeWithTemplate::run(
     }
     }
   }
-  if (NodeMap.count(FromId) == 0) {
+  auto It = NodeMap.find(FromId);
+  if (It == NodeMap.end()) {
     llvm::errs() << "Node to be replaced " << FromId
                  << " not bound in query.\n";
     llvm::report_fatal_error("FromId node not bound in MatchResult");
   }
   auto Replacement =
-      tooling::Replacement(*Result.SourceManager, &NodeMap.at(FromId), ToText,
+      tooling::Replacement(*Result.SourceManager, &It->second, ToText,
                            Result.Context->getLangOpts());
   llvm::Error Err = Replace.add(Replacement);
   if (Err) {

@kazutakahirata kazutakahirata merged commit 4acfeaf into llvm:main Mar 14, 2025
13 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_repeated_hash_lookups_clang_Tooling branch March 14, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants