Skip to content

[lldb] Fix TestGdbRemoteForkNonStop.py test #131293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

[lldb] Fix TestGdbRemoteForkNonStop.py test #131293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09aa2a5
[lldb] Rewrote with lldbutil function
sga-sc Mar 19, 2025
77f2717
[lldb] Fixed typo
sga-sc Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/packages/Python/lldbsuite/test/lldbtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2022,7 +2022,7 @@ def get_process_working_directory(self):
"""Get the working directory that should be used when launching processes for local or remote processes."""
if lldb.remote_platform:
# Remote tests set the platform working directory up in
# TestBase.setUp()
# Base.setUp()
return lldb.remote_platform.GetWorkingDirectory()
else:
# local tests change directory into each test subdirectory
Expand Down
14 changes: 7 additions & 7 deletions lldb/test/API/tools/lldb-server/TestGdbRemoteForkNonStop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *

from lldbsuite.test.lldbutil import append_to_process_working_directory
from fork_testbase import GdbRemoteForkTestBase


Expand Down Expand Up @@ -156,8 +156,8 @@ def get_all_output_via_vStdio(self, output_test):

@add_test_categories(["fork"])
def test_c_both_nonstop(self):
lock1 = self.getBuildArtifact("lock1")
lock2 = self.getBuildArtifact("lock2")
lock1 = lldbutil.append_to_process_working_directory(self, "lock1")
lock2 = lldbutil.append_to_process_working_directory(self, "lock2")
parent_pid, parent_tid, child_pid, child_tid = self.start_fork_test(
[
"fork",
Expand Down Expand Up @@ -194,8 +194,8 @@ def test_c_both_nonstop(self):

@add_test_categories(["fork"])
def test_vCont_both_nonstop(self):
lock1 = self.getBuildArtifact("lock1")
lock2 = self.getBuildArtifact("lock2")
lock1 = lldbutil.append_to_process_working_directory(self, "lock1")
lock2 = lldbutil.append_to_process_working_directory(self, "lock2")
parent_pid, parent_tid, child_pid, child_tid = self.start_fork_test(
[
"fork",
Expand Down Expand Up @@ -227,8 +227,8 @@ def test_vCont_both_nonstop(self):
self.assertIn("PID: {}".format(int(child_pid, 16)).encode(), output)

def vCont_both_nonstop_test(self, vCont_packet):
lock1 = self.getBuildArtifact("lock1")
lock2 = self.getBuildArtifact("lock2")
lock1 = lldbutil.append_to_process_working_directory(self, "lock1")
lock2 = lldbutil.append_to_process_working_directory(self, "lock2")
parent_pid, parent_tid, child_pid, child_tid = self.start_fork_test(
[
"fork",
Expand Down