[LLVM] Only enable -fno-lifetime-dse in LTO mode
#131381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Always passing this option is problematic since it is not supported by `clang.` this leads to conflicts when using extra CMake tools like `compile-commands` or `include-what-you-use`. This mainly works around a bug that showed up during the LTO build. Theoretically this can show up without LTO, but it's likely to work.
thesamesam
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Always passing this option is problematic since it is not supported by
clang.this leads to conflicts when using extra CMake tools likecompile-commandsorinclude-what-you-use. This mainly works around abug that showed up during the LTO build. Theoretically this can show up
without LTO, but it's likely to work.
This can be removed once #24952 is resolved.