[docs] Mention --discard-locals/--discard-all change for llvm-strip #131491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5-bogner
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Fangrui Song (MaskRay) ChangesPR #130704 updated llvm-strip as well. Suggested by @nga888 Full diff: https://github.com/llvm/llvm-project/pull/131491.diff 2 Files Affected:
diff --git a/llvm/docs/CommandGuide/llvm-strip.rst b/llvm/docs/CommandGuide/llvm-strip.rst
index b0777991eb901..b4d6dc08dc1ac 100644
--- a/llvm/docs/CommandGuide/llvm-strip.rst
+++ b/llvm/docs/CommandGuide/llvm-strip.rst
@@ -37,9 +37,10 @@ multiple file formats.
.. option:: --discard-all, -x
- Remove most local symbols from the output. Different file formats may limit
- this to a subset of the local symbols. For example, file and section symbols in
- ELF objects will not be discarded. Additionally, remove all debug sections.
+ Remove most local symbols not referenced by relocations from the output.
+ Different file formats may limit this to a subset of the local symbols. For
+ example, file and section symbols in ELF objects will not be discarded.
+ Additionally, remove all debug sections.
.. option:: --enable-deterministic-archives, -D
@@ -152,7 +153,7 @@ them.
.. option:: --discard-locals, -X
- Remove local symbols starting with ".L" from the output.
+ Remove local symbols starting with ".L" not referenced by relocations from the output.
.. option:: --keep-file-symbols
diff --git a/llvm/docs/ReleaseNotes.md b/llvm/docs/ReleaseNotes.md
index eb050e2747bc5..880df342447ae 100644
--- a/llvm/docs/ReleaseNotes.md
+++ b/llvm/docs/ReleaseNotes.md
@@ -165,7 +165,8 @@ Changes to the LLVM tools
* llvm-objcopy now supports the `--update-section` flag for intermediate Mach-O object files.
* llvm-strip now supports continuing to process files on encountering an error.
-* In llvm-objcopy's ELF port, `--discard-locals` and `--discard-all` now allow and preserve symbols referenced by relocations.
+* In llvm-objcopy/llvm-strip's ELF port, `--discard-locals` and `--discard-all` now allow and preserve symbols referenced by relocations.
+ (`#47468 <https://github.com/llvm/llvm-project/issues/47468>`_).
Changes to LLDB
---------------------------------
|
nga888
approved these changes
Mar 17, 2025
llvm/docs/ReleaseNotes.md
Outdated
| @@ -165,7 +165,8 @@ Changes to the LLVM tools | |||
|
|
|||
| * llvm-objcopy now supports the `--update-section` flag for intermediate Mach-O object files. | |||
| * llvm-strip now supports continuing to process files on encountering an error. | |||
| * In llvm-objcopy's ELF port, `--discard-locals` and `--discard-all` now allow and preserve symbols referenced by relocations. | |||
| * In llvm-objcopy/llvm-strip's ELF port, `--discard-locals` and `--discard-all` now allow and preserve symbols referenced by relocations. | |||
| (`#47468 <https://github.com/llvm/llvm-project/issues/47468>`_). | |||
There was a problem hiding this comment.
I'm not entirely sure of the syntax but do you mean:
([#47468](https://github.com/llvm/llvm-project/issues/47468))
There was a problem hiding this comment.
Thanks for spotting this! I thought I was writing reST..
MaskRay
deleted the
users/MaskRay/spr/docs-mention-discard-locals-discard-all-change-for-llvm-strip
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 18, 2025
…lvm-strip PR #130704 updated llvm-strip as well. Suggested by @nga888 Pull Request: llvm/llvm-project#131491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #130704 updated llvm-strip as well.
Suggested by @nga888