Skip to content

[libc++] [test] Improve test coverage for containers' scary.pass.cpp #131550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

[libc++] [test] Improve test coverage for containers' scary.pass.cpp #131550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23bc133
[libc++] [test] Improve test coverage for containers' scary.pass.cpp
halbi2 Mar 17, 2025
fe5035e
[libc++] Move SCARY tests to test/libcxx/
halbi2 Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...iners/associative/multimap/scary.pass.cpp → ...rs/associative/map/scary.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,19 @@

// <map>

// class map class multimap
// class map
// class multimap

// Extension: SCARY/N2913 iterator compatibility between map and multimap
// Extension: SCARY/N2913 iterator compatibility between map and multimap

#include <map>

#include "test_macros.h"

int main(int, char**) {
void test() {
typedef std::map<int, int> M1;
typedef std::multimap<int, int> M2;
M2::iterator i;
M1::iterator j = i;
((void)j);

return 0;
ASSERT_SAME_TYPE(M1::iterator, M2::iterator);
ASSERT_SAME_TYPE(M1::const_iterator, M2::const_iterator);
}
13 changes: 6 additions & 7 deletions ...iners/associative/multiset/scary.pass.cpp → ...rs/associative/set/scary.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,19 @@

// <set>

// class set class multiset
// class set
// class multiset

// Extension: SCARY/N2913 iterator compatibility between set and multiset
// Extension: SCARY/N2913 iterator compatibility between set and multiset

#include <set>

#include "test_macros.h"

int main(int, char**) {
void test() {
typedef std::set<int> M1;
typedef std::multiset<int> M2;
M2::iterator i;
M1::iterator j = i;
((void)j);

return 0;
ASSERT_SAME_TYPE(M1::iterator, M2::iterator);
ASSERT_SAME_TYPE(M1::const_iterator, M2::const_iterator);
}
15 changes: 8 additions & 7 deletions ...iners/unord/unord.multimap/scary.pass.cpp → ...ociative/unord.map/scary.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,21 @@

// <unordered_map>

// class unordered_map class unordered_multimap
// class unordered_map
// class unordered_multimap

// Extension: SCARY/N2913 iterator compatibility between unordered_map and unordered_multimap
// Extension: SCARY/N2913 iterator compatibility between unordered_map and unordered_multimap

#include <unordered_map>

#include "test_macros.h"

int main(int, char**) {
void test() {
typedef std::unordered_map<int, int> M1;
typedef std::unordered_multimap<int, int> M2;
M2::iterator i;
M1::iterator j = i;
((void)j);

return 0;
ASSERT_SAME_TYPE(M1::iterator, M2::iterator);
ASSERT_SAME_TYPE(M1::const_iterator, M2::const_iterator);
ASSERT_SAME_TYPE(M1::local_iterator, M2::local_iterator);
ASSERT_SAME_TYPE(M1::const_local_iterator, M2::const_local_iterator);
}
15 changes: 8 additions & 7 deletions ...iners/unord/unord.multiset/scary.pass.cpp → ...ociative/unord.set/scary.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,21 @@

// <unordered_set>

// class unordered_set class unordered_multiset
// class unordered_set
// class unordered_multiset

// Extension: SCARY/N2913 iterator compatibility between unordered_set and unordered_multiset
// Extension: SCARY/N2913 iterator compatibility between unordered_set and unordered_multiset

#include <unordered_set>

#include "test_macros.h"

int main(int, char**) {
void test() {
typedef std::unordered_set<int> M1;
typedef std::unordered_multiset<int> M2;
M2::iterator i;
M1::iterator j = i;
((void)j);

return 0;
ASSERT_SAME_TYPE(M1::iterator, M2::iterator);
ASSERT_SAME_TYPE(M1::const_iterator, M2::const_iterator);
ASSERT_SAME_TYPE(M1::local_iterator, M2::local_iterator);
ASSERT_SAME_TYPE(M1::const_local_iterator, M2::const_local_iterator);
}
33 changes: 33 additions & 0 deletions libcxx/test/libcxx/containers/container.adaptors/flat.map/scary.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20

// <flat_map>

// class flat_map
// class flat_multimap

// Extension: SCARY/N2913 iterator compatibility between flat_map and flat_multimap
// Test for the absence of this feature

#include <flat_map>
#include <type_traits>

#include "test_macros.h"

void test() {
typedef std::flat_map<int, int> M1;
typedef std::flat_multimap<int, int> M2;

static_assert(!std::is_convertible_v<M1::iterator, M2::iterator>);
static_assert(!std::is_convertible_v<M2::iterator, M1::iterator>);

static_assert(!std::is_convertible_v<M1::const_iterator, M2::const_iterator>);
static_assert(!std::is_convertible_v<M2::const_iterator, M1::const_iterator>);
}