Revert f9146ccbe940d8b8eb15e7686a511a28eb0abc6b #131656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilds. (llvm#130663)" This reverts commit f9146cc. This change causes problems in Bazel builds where system errno is set to non-zero before the tests even begin to run - see PR llvm#131650 for the disucssion on how to address this.
|
@llvm/pr-subscribers-libc Author: Alexey Samsonov (vonosmas) ChangesThis reverts commit f9146cc ([libc][bazel] explicitly use system-provided errno in Bazel builds. (#130663)) This change causes problems in Bazel builds where system errno is set to non-zero before the tests even begin to run - see PR #131650 for the disucssion on how to address this. Full diff: https://github.com/llvm/llvm-project/pull/131656.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl b/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl
index 672ce8c0723ec..f65da9e98226b 100644
--- a/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl
+++ b/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl
@@ -44,11 +44,6 @@ LIBC_CONFIGURE_OPTIONS = [
# "LIBC_COPT_STRTOFLOAT_DISABLE_EISEL_LEMIRE",
# "LIBC_COPT_STRTOFLOAT_DISABLE_SIMPLE_DECIMAL_CONVERSION",
- # Documentation in libc/src/errno/...
- # Since we're only using Bazel for overlay build for now, explicitly
- # enforce using the system-provided errno in both tests and release build.
- "LIBC_ERRNO_MODE=LIBC_ERRNO_MODE_SYSTEM",
-
# Documentation in libc/src/__support/libc_assert.h
# "LIBC_COPT_USE_C_ASSERT",
]
|
lntue
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f9146cc ([libc][bazel] explicitly use system-provided errno in Bazel builds. (#130663))
This change causes problems in Bazel builds where system errno is set to non-zero before the tests even begin to run - see PR #131650 for the disucssion on how to address this.