Skip to content

[ms] [llvm-ml] Add llvm-ml64 alias #131854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 19, 2025
Merged

[ms] [llvm-ml] Add llvm-ml64 alias #131854

merged 7 commits into from
Mar 19, 2025

Conversation

ericastor
Copy link
Contributor

@ericastor ericastor commented Mar 18, 2025

Rather than requiring users to pass -m64 to the llvm-ml driver to get 64-bit behavior, we add the llvm-ml64 alias, matching the behavior of ML.EXE and ML64.EXE.

The original flavor/bitness flags still work, but the alias should make some workflows easier.

NOTE: The logic for this already existed in the code; we're just finally adding the build/install instructions to match.

Rather than requiring users to pass `-m64` to the `llvm-ml` driver to get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior of `ML.EXE` and `ML64.EXE`.

The original flavor/bitness flags still work, but the alias should make some workflows easier.
@ericastor ericastor requested review from rnk, compnerd and mstorsjo March 18, 2025 16:37
Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, one comment about the tests.

It may be good to add to the commit message, that the logic for doing this already happened to exist in the code, we just didn't install such aliases yet.

@ericastor
Copy link
Contributor Author

Looking good overall, one comment about the tests.

It may be good to add to the commit message, that the logic for doing this already happened to exist in the code, we just didn't install such aliases yet.

Good idea; I'll try to remember to add that to the final commit message when I merge.

@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Mar 18, 2025
@mstorsjo
Copy link
Member

Good idea; I'll try to remember to add that to the final commit message when I merge.

To avoid needing to remember it (and risk to forget it), you can also edit the PR description (the first post), which is used as template for the final commit message once you go ahead and merge it.

@ericastor
Copy link
Contributor Author

Good idea; I'll try to remember to add that to the final commit message when I merge.

To avoid needing to remember it (and risk to forget it), you can also edit the PR description (the first post), which is used as template for the final commit message once you go ahead and merge it.

Ah, I couldn't figure out where the final commit message template lived! Thanks, fixed.

@ericastor
Copy link
Contributor Author

I think I've finally got the CMake logic fixed up at this point. Any final reviews?

@ericastor ericastor merged commit 3c657ce into llvm:main Mar 19, 2025
5 of 9 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Mar 19, 2025

LLVM Buildbot has detected a new failure on builder flang-aarch64-out-of-tree running on linaro-flang-aarch64-out-of-tree while building llvm,utils at step 8 "test-build-flang-unified-tree-check-flang".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/53/builds/14112

Here is the relevant piece of the build log for the reference
Step 8 (test-build-flang-unified-tree-check-flang) failure: test (failure)
******************** TEST 'Flang :: Lower/complex-operations.f90' FAILED ********************
Exit Code: 2

Command Output (stderr):
--
RUN: at line 2: bbc -hlfir=false /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/test/Lower/complex-operations.f90 -o - | /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/bin/FileCheck /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/test/Lower/complex-operations.f90
+ bbc -hlfir=false /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/test/Lower/complex-operations.f90 -o -
+ /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/bin/FileCheck /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/test/Lower/complex-operations.f90
/home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/test/Lower/complex-operations.f90:94:3: error: COMPLEX(KIND=10) is not an enabled type for this target
    complex(kind=10) :: a, b, c
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
bbc: semantic errors in /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/test/Lower/complex-operations.f90
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/bin/FileCheck /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/test/Lower/complex-operations.f90

--

********************


@llvm-ci
Copy link
Collaborator

llvm-ci commented Mar 19, 2025

LLVM Buildbot has detected a new failure on builder llvm-clang-x86_64-darwin running on doug-worker-3 while building llvm,utils at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/8620

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM :: tools/llvm-objcopy/ELF/remove-section-group.test' FAILED ********************
Exit Code: -6

Command Output (stderr):
--
RUN: at line 4: /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/yaml2obj /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/llvm/test/tools/llvm-objcopy/ELF/remove-section-group.test -o -    | /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/llvm-objcopy -R .group - -    | /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/llvm-readobj --sections -    | /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/FileCheck /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/llvm/test/tools/llvm-objcopy/ELF/remove-section-group.test
+ /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/yaml2obj /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/llvm/test/tools/llvm-objcopy/ELF/remove-section-group.test -o -
+ /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/llvm-objcopy -R .group - -
+ /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/llvm-readobj --sections -
+ /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/FileCheck /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/llvm/test/tools/llvm-objcopy/ELF/remove-section-group.test

--

********************


SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request Apr 30, 2025
Rather than requiring users to pass `-m64` to the `llvm-ml` driver to
get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior
of `ML.EXE` and `ML64.EXE`.

The original flavor/bitness flags still work, but the alias should make
some workflows easier.

NOTE: The logic for this already existed in the code; we're just finally
adding the build/install instructions to match.
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request May 15, 2025
Rather than requiring users to pass `-m64` to the `llvm-ml` driver to
get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior
of `ML.EXE` and `ML64.EXE`.

The original flavor/bitness flags still work, but the alias should make
some workflows easier.

NOTE: The logic for this already existed in the code; we're just finally
adding the build/install instructions to match.
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request May 29, 2025
Rather than requiring users to pass `-m64` to the `llvm-ml` driver to
get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior
of `ML.EXE` and `ML64.EXE`.

The original flavor/bitness flags still work, but the alias should make
some workflows easier.

NOTE: The logic for this already existed in the code; we're just finally
adding the build/install instructions to match.
SquallATF pushed a commit to SquallATF/llvm-project that referenced this pull request Jun 13, 2025
Rather than requiring users to pass `-m64` to the `llvm-ml` driver to
get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior
of `ML.EXE` and `ML64.EXE`.

The original flavor/bitness flags still work, but the alias should make
some workflows easier.

NOTE: The logic for this already existed in the code; we're just finally
adding the build/install instructions to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants