-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[ms] [llvm-ml] Add llvm-ml64 alias #131854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rather than requiring users to pass `-m64` to the `llvm-ml` driver to get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior of `ML.EXE` and `ML64.EXE`. The original flavor/bitness flags still work, but the alias should make some workflows easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall, one comment about the tests.
It may be good to add to the commit message, that the logic for doing this already happened to exist in the code, we just didn't install such aliases yet.
Good idea; I'll try to remember to add that to the final commit message when I merge. |
To avoid needing to remember it (and risk to forget it), you can also edit the PR description (the first post), which is used as template for the final commit message once you go ahead and merge it. |
Ah, I couldn't figure out where the final commit message template lived! Thanks, fixed. |
I think I've finally got the CMake logic fixed up at this point. Any final reviews? |
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/53/builds/14112 Here is the relevant piece of the build log for the reference
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/8620 Here is the relevant piece of the build log for the reference
|
Rather than requiring users to pass `-m64` to the `llvm-ml` driver to get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior of `ML.EXE` and `ML64.EXE`. The original flavor/bitness flags still work, but the alias should make some workflows easier. NOTE: The logic for this already existed in the code; we're just finally adding the build/install instructions to match.
Rather than requiring users to pass `-m64` to the `llvm-ml` driver to get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior of `ML.EXE` and `ML64.EXE`. The original flavor/bitness flags still work, but the alias should make some workflows easier. NOTE: The logic for this already existed in the code; we're just finally adding the build/install instructions to match.
Rather than requiring users to pass `-m64` to the `llvm-ml` driver to get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior of `ML.EXE` and `ML64.EXE`. The original flavor/bitness flags still work, but the alias should make some workflows easier. NOTE: The logic for this already existed in the code; we're just finally adding the build/install instructions to match.
Rather than requiring users to pass `-m64` to the `llvm-ml` driver to get 64-bit behavior, we add the `llvm-ml64` alias, matching the behavior of `ML.EXE` and `ML64.EXE`. The original flavor/bitness flags still work, but the alias should make some workflows easier. NOTE: The logic for this already existed in the code; we're just finally adding the build/install instructions to match.
Rather than requiring users to pass
-m64
to thellvm-ml
driver to get 64-bit behavior, we add thellvm-ml64
alias, matching the behavior ofML.EXE
andML64.EXE
.The original flavor/bitness flags still work, but the alias should make some workflows easier.
NOTE: The logic for this already existed in the code; we're just finally adding the build/install instructions to match.