Skip to content

[lldb] Fix TestBreakpointLocations #131890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

kastiglione
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Mar 18, 2025

@llvm/pr-subscribers-lldb

Author: Dave Lee (kastiglione)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/131890.diff

1 Files Affected:

  • (modified) lldb/test/API/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py (+2-2)
diff --git a/lldb/test/API/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py b/lldb/test/API/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py
index e0c93e3c18581..779dc16567dfd 100644
--- a/lldb/test/API/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py
+++ b/lldb/test/API/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py
@@ -47,9 +47,9 @@ def set_breakpoint(self):
         self.expect(
             "breakpoint list -f",
             "Breakpoint locations shown correctly",
+            ordered=False,
             substrs=[
-                "1: file = 'main.c', line = %d, exact_match = 0, locations = 3"
-                % self.line
+                f"1: file = 'main.c', line = {self.line}, exact_match = 0, locations = 3"
             ],
             patterns=[
                 "where = a.out`func_inlined .+unresolved, hit count = 0",

Copy link
Contributor

@luporl luporl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This fixes the WoA failure I was seeing.
Thanks for the quick fix.

@kastiglione kastiglione merged commit 5728813 into llvm:main Mar 19, 2025
10 checks passed
@kastiglione kastiglione deleted the lldb-Fix-TestBreakpointLocations branch March 19, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants