[libclc] Move fmod, remainder & remquo to the CLC library #132054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frasercrmck
force-pushed
the
libclc-clc-remainder-fmod-remquo
branch
from
ae2c1b1 to
3d3b659
Compare
It was already nominally in the CLC namespace; this commit just formally moves it over. Note that a fp16 version of __clc_remainder is now provided. It is defined as forwarding on to the fp32 version. This makes a difference in the OpenCL layer, where the fp16 remainder builtin will forward to the fp16 __clc_remainder builtin, rather than directly forwarding onto the fp32 __clc_remainder builtin. No changes to the generated code for non-SPIR-V targets is observed.
frasercrmck
force-pushed
the
libclc-clc-remainder-fmod-remquo
branch
from
3d3b659 to
02aacb0
Compare
frasercrmck
changed the title
arsenm
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions were already nominally in the CLC namespace; this commit just formally moves them over.
Note that 'half' versions of these CLC functions are now provided. Previously the corresponding OpenCL builtins would forward directly to the 'float' versions of the CLC builtins. Now the OpenCL builtins call the 'half' CLC builtins, which themselves call the 'float' CLC versions. This keeps the interface between the OpenCL and CLC libraries neater and keeps the CLC library self-contained.
No changes to the generated code for non-SPIR-V targets is observed.