Skip to content

[libc++][chrono] Adds a missing main include. #132100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

mordante
Copy link
Member

No description provided.

@mordante mordante requested a review from a team as a code owner March 19, 2025 21:04
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 19, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 19, 2025

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/132100.diff

1 Files Affected:

  • (modified) libcxx/include/chrono (+1)
diff --git a/libcxx/include/chrono b/libcxx/include/chrono
index d8006720c495c..a3367f89ee11d 100644
--- a/libcxx/include/chrono
+++ b/libcxx/include/chrono
@@ -1073,6 +1073,7 @@ constexpr chrono::year                                  operator ""y(unsigned lo
 
 #    if _LIBCPP_HAS_TIME_ZONE_DATABASE && _LIBCPP_HAS_FILESYSTEM && _LIBCPP_HAS_LOCALIZATION
 #      include <__chrono/leap_second.h>
+#      include <__chrono/gps_clock.h>
 #      include <__chrono/tai_clock.h>
 #      include <__chrono/time_zone.h>
 #      include <__chrono/time_zone_link.h>

Copy link

github-actions bot commented Mar 19, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm surprised why this wasn't caught by CI?

@mordante
Copy link
Member Author

LGTM but I'm surprised why this wasn't caught by CI?

Me too. I noticed it while looking at other things. It was indirectly included by other __chrono headers, but I would expect the modular build to complain.

Copy link
Contributor

@frederick-vs-ja frederick-vs-ja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although formatting issue should be fixed).

@mordante mordante force-pushed the review/adds_missing_include branch from 3189eaf to f4c47a3 Compare March 20, 2025 16:59
@mordante mordante merged commit f60bec9 into llvm:main Mar 21, 2025
83 checks passed
@mordante mordante deleted the review/adds_missing_include branch March 21, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants