[LLD] [COFF] Add a few more mingw libs to skip autoexports for #132289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-platform-windows @llvm/pr-subscribers-lld-coff Author: Martin Storsjö (mstorsjo) Changes"libmsvcrt-os" was added to the list of excluded libs in binutils in 9d9c67b06c1bf4c4550e3de0eb575c2bfbe96df9 in 2017. "libucrt" was added in c4a8df19ba0a82aa8dea88d9f72ed9e63cb1fa84 in 2022. "libucrtapp" isn't in the binutils exclusion list yet, but I'll submit a patch for that soon. Since Full diff: https://github.com/llvm/llvm-project/pull/132289.diff 1 Files Affected:
diff --git a/lld/COFF/MinGW.cpp b/lld/COFF/MinGW.cpp
index ca5dfbcc7e47c..5f8abf7f1e232 100644
--- a/lld/COFF/MinGW.cpp
+++ b/lld/COFF/MinGW.cpp
@@ -52,7 +52,10 @@ AutoExporter::AutoExporter(
"libflang_rt.runtime",
"libunwind",
"libmsvcrt",
+ "libmsvcrt-os",
"libucrtbase",
+ "libucrt",
+ "libucrtapp",
};
excludeObjects = {
|
|
@llvm/pr-subscribers-lld Author: Martin Storsjö (mstorsjo) Changes"libmsvcrt-os" was added to the list of excluded libs in binutils in 9d9c67b06c1bf4c4550e3de0eb575c2bfbe96df9 in 2017. "libucrt" was added in c4a8df19ba0a82aa8dea88d9f72ed9e63cb1fa84 in 2022. "libucrtapp" isn't in the binutils exclusion list yet, but I'll submit a patch for that soon. Since Full diff: https://github.com/llvm/llvm-project/pull/132289.diff 1 Files Affected:
diff --git a/lld/COFF/MinGW.cpp b/lld/COFF/MinGW.cpp
index ca5dfbcc7e47c..5f8abf7f1e232 100644
--- a/lld/COFF/MinGW.cpp
+++ b/lld/COFF/MinGW.cpp
@@ -52,7 +52,10 @@ AutoExporter::AutoExporter(
"libflang_rt.runtime",
"libunwind",
"libmsvcrt",
+ "libmsvcrt-os",
"libucrtbase",
+ "libucrt",
+ "libucrtapp",
};
excludeObjects = {
|
"libmsvcrt-os" was added to the list of excluded libs in binutils in 9d9c67b06c1bf4c4550e3de0eb575c2bfbe96df9 in 2017. "libucrt" was added in c4a8df19ba0a82aa8dea88d9f72ed9e63cb1fa84 in 2022. "libucrtapp" isn't in the binutils exclusion list yet, but I'll submit a patch for that soon. Since 0d403d5dd13ce22c07418058f3b640708992890c in mingw-w64 (in 2020), there's such a third variant of the UCRT import library available. Since 18df3e8323dcf9fdfec56b5f12c04a9c723a0931 in 2025, "libpthread" and "libwinpthread" are also excluded.
mstorsjo
force-pushed
the
lld-skip-autoexport
branch
from
71b3fd8 to
e2a95c2
Compare
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/18119 Here is the relevant piece of the build log for the reference |
|
Can we cherry-pick this to 20.x? |
Sure, that sounds quite reasonable to me. |
|
/cherry-pick af93db9 |
|
/pull-request #132478 |
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Mar 25, 2025
…132289) "libmsvcrt-os" was added to the list of excluded libs in binutils in 9d9c67b06c1bf4c4550e3de0eb575c2bfbe96df9 in 2017. "libucrt" was added in c4a8df19ba0a82aa8dea88d9f72ed9e63cb1fa84 in 2022. "libucrtapp" isn't in the binutils exclusion list yet, but a patch for adding it has been submitted. Since 0d403d5dd13ce22c07418058f3b640708992890c in mingw-w64 (in 2020), there's such a third variant of the UCRT import library available. Since 18df3e8323dcf9fdfec56b5f12c04a9c723a0931 in 2025, "libpthread" and "libwinpthread" are also excluded. (cherry picked from commit af93db9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"libmsvcrt-os" was added to the list of excluded libs in binutils in 9d9c67b06c1bf4c4550e3de0eb575c2bfbe96df9 in 2017.
"libucrt" was added in c4a8df19ba0a82aa8dea88d9f72ed9e63cb1fa84 in 2022.
"libucrtapp" isn't in the binutils exclusion list yet, but I'll submit a patch for that soon. Since
0d403d5dd13ce22c07418058f3b640708992890c in mingw-w64 (in 2020), there's such a third variant of the UCRT import library available.
Since 18df3e8323dcf9fdfec56b5f12c04a9c723a0931 in 2025, "libpthread" and "libwinpthread" are also excluded.