libcxx: In gdb test detect execute_mi with feature check instead of version check.

[pcc]

The existing version check can lead to test failures on some distribution
packages of gdb where not all components of the version number are
integers, such as Fedora where gdb.VERSION can be something like
"15.2-4.fc41". Fix it by replacing the version check with a feature check.

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Peter Collingbourne (pcc)

Changes

The existing version check can lead to test failures on some distribution
packages of gdb where not all components of the version number are
integers, such as Fedora where gdb.VERSION can be something like
"15.2-4.fc41". Fix it by replacing the version check with a feature check.

---

Full diff: https://github.com/llvm/llvm-project/pull/132291.diff

1 Files Affected:

• (modified) libcxx/test/libcxx/gdb/gdb_pretty_printer_test.py (+1-1)

diff --git a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.py b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.py
index 254a61a8c633e..630b90c9d77a6 100644
--- a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.py
+++ b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.py
@@ -30,7 +30,7 @@
 # we exit.
 has_run_tests = False
 
-has_execute_mi = tuple(map(int, gdb.VERSION.split("."))) >= (14, 2)
+has_execute_mi = 'execute_mi' in gdb.__dict__
 
 class CheckResult(gdb.Command):
     def __init__(self):

[github-actions]

✅ With the latest revision this PR passed the Python code formatter.

[pcc]

Ping @ldionne

[philnik777]

Is it documented somewhere that you're allowed to use gdb.__dict__?

[pcc]

I guess gdb.__dict__ may not correspond to the actual attributes on the object because GDB could start using a custom tp_getattro for that object, although that seems unlikely. I switched to checking the result of getattr which should be equivalent to checking whether gdb.execute_mi would result in an AttributeError.

[philnik777]

It looks like your merge base is wrong.

[pcc]

That's just what spr does, it will be applied onto main when it lands.

…

On Tue, Apr 8, 2025, 23:52 Nikolas Klauser ***@***.***> wrote: It looks like your merge base is wrong. — Reply to this email directly, view it on GitHub <#132291 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADHYQB3BL4FF3UGLJZJXK32YS7T3AVCNFSM6AAAAABZORGEPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBYGUYTAOBYGM> . You are receiving this because you authored the thread.Message ID: ***@***.***> *philnik777* left a comment (llvm/llvm-project#132291) <#132291 (comment)> It looks like your merge base is wrong. — Reply to this email directly, view it on GitHub <#132291 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADHYQB3BL4FF3UGLJZJXK32YS7T3AVCNFSM6AAAAABZORGEPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBYGUYTAOBYGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[philnik777]

Could you not use spr in that case? I can't see the diff as it would be merged AFAICT.

[pcc]

Odd, if I go to https://github.com/llvm/llvm-project/pull/132291/files in an incognito tab it just looks like this to me and that's what would be applied.

…

On Wed, Apr 9, 2025, 00:03 Nikolas Klauser ***@***.***> wrote: Could you not use spr in that case? I can't see the diff as it would be merged AFAICT. — Reply to this email directly, view it on GitHub <#132291 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADHYQCKMPOMQS2VXD4L5PL2YTA3RAVCNFSM6AAAAABZORGEPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBYGU2DGNJZGE> . You are receiving this because you authored the thread.Message ID: ***@***.***> *philnik777* left a comment (llvm/llvm-project#132291) <#132291 (comment)> Could you not use spr in that case? I can't see the diff as it would be merged AFAICT. — Reply to this email directly, view it on GitHub <#132291 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADHYQCKMPOMQS2VXD4L5PL2YTA3RAVCNFSM6AAAAABZORGEPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBYGU2DGNJZGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mordante]

@philnik777 FWIW I also see a normal diff in the webui.

[philnik777]

LGTM assuming the diff landed is the same I see. I'm really not a fan of complicating things unnecessarily though.