[libclc] link_bc target should depends on target builtins.link.clc-arch_suffix #132338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frasercrmck could you please review? thanks |
…ch_suffix
Currently link_bc command depends on the bitcode file that is associated
with custom target builtins.link.clc-arch_suffix.
On windows we randomly see following error:
`
Generating builtins.link.clc-${ARCH}--.bc
Generating builtins.link.libspirv-${ARCH}.bc
error : The requested operation cannot be performed on a file with a user-mapped section open.
`
I suspect that builtins.link.clc-${ARCH}--.bc file is being generated
while it is being used in link_bc.
This PR adds target-level dependency to ensure builtins.link.clc-${ARCH}--.bc
is generated first.
wenju-he
force-pushed
the
libclc-link_bc-depends
branch
from
a423c4d to
6ce54aa
Compare
frasercrmck
reviewed
Mar 21, 2025
libclc/cmake/modules/AddLibclc.cmake
Outdated
| @@ -211,8 +211,9 @@ endfunction() | |||
| # * ALIASES <string> ... | |||
| # List of aliases | |||
| # * INTERNAL_LINK_DEPENDENCIES <string> ... | |||
There was a problem hiding this comment.
If this comment is to be updated it should probably say <target> ...? What do you think?
libclc/cmake/modules/AddLibclc.cmake
Outdated
| @@ -313,8 +314,8 @@ function(add_libclc_builtin_set) | |||
| INTERNALIZE | |||
| TARGET ${builtins_link_lib_tgt} | |||
| INPUTS $<TARGET_PROPERTY:${builtins_link_lib_tmp_tgt},TARGET_FILE> | |||
| ${ARG_INTERNAL_LINK_DEPENDENCIES} | |||
| DEPENDENCIES ${builtins_link_lib_tmp_tgt} | |||
| $<TARGET_PROPERTY:${ARG_INTERNAL_LINK_DEPENDENCIES},TARGET_FILE> | |||
There was a problem hiding this comment.
I'm not sure this will work correctly if ARG_INTERNAL_LINK_DEPENDENCIES is a list. You won't be able to find a property on foo-target;bar-target, for example. It might silently do the wrong thing, or it might error, I'm not sure.
There was a problem hiding this comment.
thanks, changed to reading TARGE_FILE from each target
|
I've tested on Windows for half a day, it seems this PR can fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently link_bc command depends on the bitcode file that is associated with custom target builtins.link.clc-arch_suffix.
On windows we randomly see following error:
Generating builtins.link.clc-${ARCH}--.bc Generating builtins.link.libspirv-${ARCH}.bc error : The requested operation cannot be performed on a file with a user-mapped section open.I suspect that builtins.link.clc-${ARCH}--.bc file is being generated while it is being used in link_bc.
This PR adds target-level dependency to ensure builtins.link.clc-${ARCH}--.bc is generated first.