Skip to content

release/20.x: [clang][docs] Move -Wnontrivial-memcall to added flags. #132367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

R-Goc
Copy link
Contributor

@R-Goc R-Goc commented Mar 21, 2025

-Wnon-trivial-memcall was incorrectly added to modified flags instead of added flags. This commit moves it to the added compiler flags.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Mar 21, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 21, 2025

@llvm/pr-subscribers-clang

Author: None (R-Goc)

Changes

-Wnon-trivial-memcall was incorrectly added to modified flags instead of added flags. This commit moves it to the added compiler flags.


Full diff: https://github.com/llvm/llvm-project/pull/132367.diff

1 Files Affected:

  • (modified) clang/docs/ReleaseNotes.rst (+5-5)
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 03b68271b7864..8560b2a7adf95 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -545,6 +545,11 @@ New Compiler Flags
 - The ``-Warray-compare-cxx26`` warning has been added to warn about array comparison
   starting from C++26, this warning is enabled as an error by default.
 
+- The ``-Wnontrivial-memcall`` warning has been added to warn about
+  passing non-trivially-copyable destination parameter to ``memcpy``,
+  ``memset`` and similar functions for which it is a documented undefined
+  behavior. It is implied by ``-Wnontrivial-memaccess``
+
 - clang-cl and clang-dxc now support ``-fdiagnostics-color=[auto|never|always]``
   in addition to ``-f[no-]color-diagnostics``.
 
@@ -576,11 +581,6 @@ Modified Compiler Flags
   to utilize these vector libraries. The behavior for all other vector function
   libraries remains unchanged.
 
-- The ``-Wnontrivial-memcall`` warning has been added to warn about
-  passing non-trivially-copyable destination parameter to ``memcpy``,
-  ``memset`` and similar functions for which it is a documented undefined
-  behavior. It is implied by ``-Wnontrivial-memaccess``
-
 - Added ``-fmodules-reduced-bmi`` flag corresponding to
   ``-fexperimental-modules-reduced-bmi`` flag. The ``-fmodules-reduced-bmi`` flag
   is intended to be enabled by default in the future.

@R-Goc R-Goc changed the title Release 20.x: [clang][docs] Move non-trivial-memcall to added flags. release/20.x: [clang][docs] Move -Wnon-trivial-memcall to added flags. Mar 21, 2025
-Wnontrivial-memcall was incorrectly added to modified flags instead of
added flags. This commit moves it to the added compiler flags.
@R-Goc R-Goc changed the title release/20.x: [clang][docs] Move -Wnon-trivial-memcall to added flags. release/20.x: [clang][docs] Move -Wnontrivial-memcall to added flags. Mar 21, 2025
@mmuetzel mmuetzel added this to the LLVM 20.X Release milestone Mar 21, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Mar 21, 2025
@R-Goc
Copy link
Contributor Author

R-Goc commented Mar 21, 2025

Not sure about the version check. Should this just be ignored?

@tstellar tstellar moved this from Needs Triage to Needs Review in LLVM Release Status Mar 25, 2025
@tstellar tstellar merged commit 943b432 into llvm:release/20.x Mar 29, 2025
15 of 16 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in LLVM Release Status Mar 29, 2025
Copy link

@R-Goc (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
Development

Successfully merging this pull request may close these issues.

4 participants