Skip to content

Minor unused variable error for sanitizer builds #132372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

chandraghale
Copy link
Contributor

@chandraghale chandraghale commented Mar 21, 2025

Fix #132371
Minor error , sanitizer builds are failing for unused variable.
sanitizer-aarch64-linux/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:11764:17: error: unused variable 'I' [-Werror,-Wunused-variable]
11764 | for (unsigned I : llvm::seq(NumFlags))

This was modified as part of #129938 , which got missed.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:modules C++20 modules and Clang Header Modules labels Mar 21, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 21, 2025

@llvm/pr-subscribers-clang

Author: CHANDRA GHALE (chandraghale)

Changes

Fix to issue https://github.com/llvm/llvm-project/issues/132371
Minor error , sanitizer builds are failing for unused variable.
sanitizer-aarch64-linux/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:11764:17: error: unused variable 'I' [-Werror,-Wunused-variable]
11764 | for (unsigned I : llvm::seq<unsigned>(NumFlags))

This was modified as part of #129938 , which got missed.


Full diff: https://github.com/llvm/llvm-project/pull/132372.diff

1 Files Affected:

  • (modified) clang/lib/Serialization/ASTReader.cpp (+1-1)
diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp
index 930134bcd6501..c66ea5a2c0346 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -11761,7 +11761,7 @@ void OMPClauseReader::VisitOMPReductionClause(OMPReductionClause *C) {
   unsigned NumFlags = Record.readInt();
   SmallVector<bool, 16> Flags;
   Flags.reserve(NumFlags);
-  for (unsigned I : llvm::seq<unsigned>(NumFlags))
+  for ([[maybe_unused]] unsigned I : llvm::seq<unsigned>(NumFlags))
     Flags.push_back(Record.readInt());
   C->setPrivateVariableReductionFlags(Flags);
 }

@llvmbot
Copy link
Member

llvmbot commented Mar 21, 2025

@llvm/pr-subscribers-clang-modules

Author: CHANDRA GHALE (chandraghale)

Changes

Fix to issue https://github.com/llvm/llvm-project/issues/132371
Minor error , sanitizer builds are failing for unused variable.
sanitizer-aarch64-linux/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:11764:17: error: unused variable 'I' [-Werror,-Wunused-variable]
11764 | for (unsigned I : llvm::seq<unsigned>(NumFlags))

This was modified as part of #129938 , which got missed.


Full diff: https://github.com/llvm/llvm-project/pull/132372.diff

1 Files Affected:

  • (modified) clang/lib/Serialization/ASTReader.cpp (+1-1)
diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp
index 930134bcd6501..c66ea5a2c0346 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -11761,7 +11761,7 @@ void OMPClauseReader::VisitOMPReductionClause(OMPReductionClause *C) {
   unsigned NumFlags = Record.readInt();
   SmallVector<bool, 16> Flags;
   Flags.reserve(NumFlags);
-  for (unsigned I : llvm::seq<unsigned>(NumFlags))
+  for ([[maybe_unused]] unsigned I : llvm::seq<unsigned>(NumFlags))
     Flags.push_back(Record.readInt());
   C->setPrivateVariableReductionFlags(Flags);
 }

Copy link
Contributor

@frederick-vs-ja frederick-vs-ja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I modified the PR description so GitHub can automatically associate this PR with the issue.

@chandraghale chandraghale merged commit ff8a960 into llvm:main Mar 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:modules C++20 modules and Clang Header Modules clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanitizer Build Failure : ASTReader.cpp error: unused variable 'I' [-Werror,-Wunused-variable]
4 participants