-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[lldb][NFC] use platform independent path separator in testSettings.py. #132392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The build bot was failing when connecting from windows to linux. Signed-off-by: Ebuka Ezike <[email protected]>
@llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) ChangesThe build bot was failing when running remote test from windows to linux. Full diff: https://github.com/llvm/llvm-project/pull/132392.diff 1 Files Affected:
diff --git a/lldb/test/API/commands/settings/TestSettings.py b/lldb/test/API/commands/settings/TestSettings.py
index 6b89ff76a2900..045b93dab2e2a 100644
--- a/lldb/test/API/commands/settings/TestSettings.py
+++ b/lldb/test/API/commands/settings/TestSettings.py
@@ -1018,7 +1018,9 @@ def test_settings_api(self):
# Test OptionValueFileSpec and OptionValueFileSpecList
setting_path = "target.debug-file-search-paths"
- setting_value = ["/tmp" "/tmp2"]
+ path1 = os.path.join(self.getSourceDir(), "tmp")
+ path2 = os.path.join(self.getSourceDir(), "tmp2")
+ setting_value = [path1, path2]
self.runCmd("settings set %s %s" % (setting_path, " ".join(setting_value)))
settings_json = self.get_setting_json(setting_path)
self.assertEqual(settings_json, setting_value)
|
Add quotes around variables Co-authored-by: Pavel Labath <[email protected]>
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/18611 Here is the relevant piece of the build log for the reference
|
Now https://lab.llvm.org/buildbot/#/builders/195/builds/6519 is broken too. Please fix it ASAP. |
The build bot was failing when running remote test from windows to linux.
From #131683