Skip to content

[lldb][NFC] use platform independent path separator in testSettings.py. #132392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

da-viper
Copy link
Contributor

@da-viper da-viper commented Mar 21, 2025

The build bot was failing when running remote test from windows to linux.

From #131683

The build bot was failing when connecting from windows to linux.

Signed-off-by: Ebuka Ezike <[email protected]>
@da-viper da-viper requested a review from JDevlieghere as a code owner March 21, 2025 13:06
@llvmbot llvmbot added the lldb label Mar 21, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 21, 2025

@llvm/pr-subscribers-lldb

Author: Ebuka Ezike (da-viper)

Changes

The build bot was failing when running remote test from windows to linux.


Full diff: https://github.com/llvm/llvm-project/pull/132392.diff

1 Files Affected:

  • (modified) lldb/test/API/commands/settings/TestSettings.py (+3-1)
diff --git a/lldb/test/API/commands/settings/TestSettings.py b/lldb/test/API/commands/settings/TestSettings.py
index 6b89ff76a2900..045b93dab2e2a 100644
--- a/lldb/test/API/commands/settings/TestSettings.py
+++ b/lldb/test/API/commands/settings/TestSettings.py
@@ -1018,7 +1018,9 @@ def test_settings_api(self):
 
         # Test OptionValueFileSpec and OptionValueFileSpecList
         setting_path = "target.debug-file-search-paths"
-        setting_value = ["/tmp" "/tmp2"]
+        path1 = os.path.join(self.getSourceDir(), "tmp")
+        path2 = os.path.join(self.getSourceDir(), "tmp2")
+        setting_value = [path1, path2]
         self.runCmd("settings set %s %s" % (setting_path, " ".join(setting_value)))
         settings_json = self.get_setting_json(setting_path)
         self.assertEqual(settings_json, setting_value)

Add quotes around variables

Co-authored-by: Pavel Labath <[email protected]>
@da-viper da-viper merged commit 5286511 into llvm:main Mar 21, 2025
8 of 10 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Mar 21, 2025

LLVM Buildbot has detected a new failure on builder lldb-x86_64-debian running on lldb-x86_64-debian while building lldb at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/18611

Here is the relevant piece of the build log for the reference
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: tools/lldb-server/TestGdbRemoteForkResume.py (73 of 2801)
PASS: lldb-api :: source-manager/TestSourceManager.py (74 of 2801)
PASS: lldb-api :: tools/lldb-server/TestGdbRemoteAuxvSupport.py (75 of 2801)
PASS: lldb-api :: commands/watchpoints/hello_watchlocation/TestWatchLocation.py (76 of 2801)
PASS: lldb-api :: tools/lldb-dap/console/TestDAP_console.py (77 of 2801)
PASS: lldb-api :: lang/cpp/namespace/TestNamespaceLookup.py (78 of 2801)
PASS: lldb-api :: types/TestLongTypes.py (79 of 2801)
PASS: lldb-api :: functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py (80 of 2801)
PASS: lldb-api :: tools/lldb-server/vCont-threads/TestPartialResume.py (81 of 2801)
PASS: lldb-api :: functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py (82 of 2801)
FAIL: lldb-api :: commands/settings/TestSettings.py (83 of 2801)
******************** TEST 'lldb-api :: commands/settings/TestSettings.py' FAILED ********************
Script:
--
/usr/bin/python3 /home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/worker/2.0.1/lldb-x86_64-debian/build/./lib --env LLVM_INCLUDE_DIR=/home/worker/2.0.1/lldb-x86_64-debian/build/include --env LLVM_TOOLS_DIR=/home/worker/2.0.1/lldb-x86_64-debian/build/./bin --arch x86_64 --build-dir /home/worker/2.0.1/lldb-x86_64-debian/build/lldb-test-build.noindex --lldb-module-cache-dir /home/worker/2.0.1/lldb-x86_64-debian/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/worker/2.0.1/lldb-x86_64-debian/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/worker/2.0.1/lldb-x86_64-debian/build/./bin/lldb --compiler /home/worker/2.0.1/lldb-x86_64-debian/build/./bin/clang --dsymutil /home/worker/2.0.1/lldb-x86_64-debian/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/worker/2.0.1/lldb-x86_64-debian/build/./bin --lldb-obj-root /home/worker/2.0.1/lldb-x86_64-debian/build/tools/lldb --lldb-libs-dir /home/worker/2.0.1/lldb-x86_64-debian/build/./lib -t /home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/commands/settings -p TestSettings.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 21.0.0git (https://github.com/llvm/llvm-project.git revision 5286511adc94529c2d0ee9ea37c121ff7eaea223)
  clang revision 5286511adc94529c2d0ee9ea37c121ff7eaea223
  llvm revision 5286511adc94529c2d0ee9ea37c121ff7eaea223
Skipping the following test categories: ['libc++', 'dsym', 'gmodules', 'debugserver', 'objc']

--
Command Output (stderr):
--
Change dir to: /home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/commands/settings
runCmd: settings clear -all

output: 

runCmd: settings set symbols.enable-external-lookup false

output: 

runCmd: settings set target.inherit-tcc true

output: 

runCmd: settings set target.disable-aslr false

output: 

runCmd: settings set target.detach-on-error false

output: 


@slydiman
Copy link
Contributor

Now https://lab.llvm.org/buildbot/#/builders/195/builds/6519 is broken too. Please fix it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants