[llvm] Use *Set::insert_range (NFC) #132591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenseSet, SmallPtrSet, SmallSet, SetVector, and StringSet recently gained C++23-style insert_range. This patch uses insert_range with iterator ranges. For each case, I've verified that foos is defined as make_range(foo_begin(), foo_end()) or in a similar manner.
llvmbot
added
vectorizers
LTO
|
@llvm/pr-subscribers-vectorizers @llvm/pr-subscribers-llvm-transforms Author: Kazu Hirata (kazutakahirata) ChangesDenseSet, SmallPtrSet, SmallSet, SetVector, and StringSet recently Full diff: https://github.com/llvm/llvm-project/pull/132591.diff 8 Files Affected:
diff --git a/llvm/lib/IR/Type.cpp b/llvm/lib/IR/Type.cpp
index 0d400bdbdc775..34732f75ebecb 100644
--- a/llvm/lib/IR/Type.cpp
+++ b/llvm/lib/IR/Type.cpp
@@ -553,7 +553,7 @@ Error StructType::checkBody(ArrayRef<Type *> Elements) {
if (Ty == this)
return createStringError(Twine("identified structure type '") +
getName() + "' is recursive");
- Worklist.insert(Ty->subtype_begin(), Ty->subtype_end());
+ Worklist.insert_range(Ty->subtypes());
}
return Error::success();
}
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 5934f7adffb93..ed86a10c3a25f 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -7215,7 +7215,7 @@ void Verifier::verifyCompileUnits() {
auto *CUs = M.getNamedMetadata("llvm.dbg.cu");
SmallPtrSet<const Metadata *, 2> Listed;
if (CUs)
- Listed.insert(CUs->op_begin(), CUs->op_end());
+ Listed.insert_range(CUs->operands());
for (const auto *CU : CUVisited)
CheckDI(Listed.count(CU), "DICompileUnit not listed in llvm.dbg.cu", CU);
CUVisited.clear();
diff --git a/llvm/lib/LTO/LTO.cpp b/llvm/lib/LTO/LTO.cpp
index b12be4ac86aae..97d23feff230f 100644
--- a/llvm/lib/LTO/LTO.cpp
+++ b/llvm/lib/LTO/LTO.cpp
@@ -1439,9 +1439,9 @@ class InProcessThinBackend : public ThinBackendProc {
AddStream(std::move(AddStream)), Cache(std::move(Cache)),
ShouldEmitIndexFiles(ShouldEmitIndexFiles) {
auto &Defs = CombinedIndex.cfiFunctionDefs();
- CfiFunctionDefs.insert(Defs.guid_begin(), Defs.guid_end());
+ CfiFunctionDefs.insert_range(Defs.guids());
auto &Decls = CombinedIndex.cfiFunctionDecls();
- CfiFunctionDecls.insert(Decls.guid_begin(), Decls.guid_end());
+ CfiFunctionDecls.insert_range(Decls.guids());
}
virtual Error runThinLTOBackendThread(
diff --git a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
index 2bec5559abd16..8a30a3e8d22e2 100644
--- a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
+++ b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
@@ -1972,7 +1972,7 @@ class LowerMatrixIntrinsics {
if (CurrI->mayHaveSideEffects() || CurrI->mayReadFromMemory())
return;
ToHoist.push_back(CurrI);
- WorkList.insert(CurrI->op_begin(), CurrI->op_end());
+ WorkList.insert_range(CurrI->operands());
}
sort(ToHoist, [this](Instruction *A, Instruction *B) {
diff --git a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
index d1c7eaf85de7e..ca90bb65f5708 100644
--- a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
@@ -102,7 +102,7 @@ static bool partitionOuterLoopBlocks(
Loop &Root, Loop &JamLoop, BasicBlockSet &JamLoopBlocks,
DenseMap<Loop *, BasicBlockSet> &ForeBlocksMap,
DenseMap<Loop *, BasicBlockSet> &AftBlocksMap, DominatorTree &DT) {
- JamLoopBlocks.insert(JamLoop.block_begin(), JamLoop.block_end());
+ JamLoopBlocks.insert_range(JamLoop.blocks());
for (Loop *L : Root.getLoopsInPreorder()) {
if (L == &JamLoop)
@@ -122,7 +122,7 @@ static bool partitionOuterLoopBlocks(Loop *L, Loop *SubLoop,
BasicBlockSet &SubLoopBlocks,
BasicBlockSet &AftBlocks,
DominatorTree *DT) {
- SubLoopBlocks.insert(SubLoop->block_begin(), SubLoop->block_end());
+ SubLoopBlocks.insert_range(SubLoop->blocks());
return partitionLoopBlocks(*L, ForeBlocks, AftBlocks, *DT);
}
diff --git a/llvm/lib/Transforms/Utils/LoopUtils.cpp b/llvm/lib/Transforms/Utils/LoopUtils.cpp
index 96d7b3342349e..dd9f1d890b9c5 100644
--- a/llvm/lib/Transforms/Utils/LoopUtils.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUtils.cpp
@@ -701,7 +701,7 @@ void llvm::deleteDeadLoop(Loop *L, DominatorTree *DT, ScalarEvolution *SE,
// otherwise our loop iterators won't work.
SmallPtrSet<BasicBlock *, 8> blocks;
- blocks.insert(L->block_begin(), L->block_end());
+ blocks.insert_range(L->blocks());
for (BasicBlock *BB : blocks)
LI->removeBlock(BB);
diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
index 574ded9948aac..823af82191c5a 100644
--- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -2970,7 +2970,7 @@ void InnerLoopVectorizer::sinkScalarOperands(Instruction *PredInst) {
// may have failed to sink I's operands (recursively), which we try
// (again) here.
if (I->getParent() == PredBB) {
- Worklist.insert(I->op_begin(), I->op_end());
+ Worklist.insert_range(I->operands());
continue;
}
@@ -2985,7 +2985,7 @@ void InnerLoopVectorizer::sinkScalarOperands(Instruction *PredInst) {
// Move the instruction to the beginning of the predicated block, and add
// it's operands to the worklist.
I->moveBefore(PredBB->getFirstInsertionPt());
- Worklist.insert(I->op_begin(), I->op_end());
+ Worklist.insert_range(I->operands());
// The sinking may have enabled other instructions to be sunk, so we will
// need to iterate.
diff --git a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
index 08e16b53cd1e7..6c0100389d736 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
@@ -582,7 +582,7 @@ static SmallVector<VPUser *> collectUsersRecursively(VPValue *V) {
if (isa<VPHeaderPHIRecipe>(Cur))
continue;
for (VPValue *V : Cur->definedValues())
- Users.insert(V->user_begin(), V->user_end());
+ Users.insert_range(V->users());
}
return Users.takeVector();
}
|
|
@llvm/pr-subscribers-lto Author: Kazu Hirata (kazutakahirata) ChangesDenseSet, SmallPtrSet, SmallSet, SetVector, and StringSet recently Full diff: https://github.com/llvm/llvm-project/pull/132591.diff 8 Files Affected:
diff --git a/llvm/lib/IR/Type.cpp b/llvm/lib/IR/Type.cpp
index 0d400bdbdc775..34732f75ebecb 100644
--- a/llvm/lib/IR/Type.cpp
+++ b/llvm/lib/IR/Type.cpp
@@ -553,7 +553,7 @@ Error StructType::checkBody(ArrayRef<Type *> Elements) {
if (Ty == this)
return createStringError(Twine("identified structure type '") +
getName() + "' is recursive");
- Worklist.insert(Ty->subtype_begin(), Ty->subtype_end());
+ Worklist.insert_range(Ty->subtypes());
}
return Error::success();
}
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 5934f7adffb93..ed86a10c3a25f 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -7215,7 +7215,7 @@ void Verifier::verifyCompileUnits() {
auto *CUs = M.getNamedMetadata("llvm.dbg.cu");
SmallPtrSet<const Metadata *, 2> Listed;
if (CUs)
- Listed.insert(CUs->op_begin(), CUs->op_end());
+ Listed.insert_range(CUs->operands());
for (const auto *CU : CUVisited)
CheckDI(Listed.count(CU), "DICompileUnit not listed in llvm.dbg.cu", CU);
CUVisited.clear();
diff --git a/llvm/lib/LTO/LTO.cpp b/llvm/lib/LTO/LTO.cpp
index b12be4ac86aae..97d23feff230f 100644
--- a/llvm/lib/LTO/LTO.cpp
+++ b/llvm/lib/LTO/LTO.cpp
@@ -1439,9 +1439,9 @@ class InProcessThinBackend : public ThinBackendProc {
AddStream(std::move(AddStream)), Cache(std::move(Cache)),
ShouldEmitIndexFiles(ShouldEmitIndexFiles) {
auto &Defs = CombinedIndex.cfiFunctionDefs();
- CfiFunctionDefs.insert(Defs.guid_begin(), Defs.guid_end());
+ CfiFunctionDefs.insert_range(Defs.guids());
auto &Decls = CombinedIndex.cfiFunctionDecls();
- CfiFunctionDecls.insert(Decls.guid_begin(), Decls.guid_end());
+ CfiFunctionDecls.insert_range(Decls.guids());
}
virtual Error runThinLTOBackendThread(
diff --git a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
index 2bec5559abd16..8a30a3e8d22e2 100644
--- a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
+++ b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
@@ -1972,7 +1972,7 @@ class LowerMatrixIntrinsics {
if (CurrI->mayHaveSideEffects() || CurrI->mayReadFromMemory())
return;
ToHoist.push_back(CurrI);
- WorkList.insert(CurrI->op_begin(), CurrI->op_end());
+ WorkList.insert_range(CurrI->operands());
}
sort(ToHoist, [this](Instruction *A, Instruction *B) {
diff --git a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
index d1c7eaf85de7e..ca90bb65f5708 100644
--- a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
@@ -102,7 +102,7 @@ static bool partitionOuterLoopBlocks(
Loop &Root, Loop &JamLoop, BasicBlockSet &JamLoopBlocks,
DenseMap<Loop *, BasicBlockSet> &ForeBlocksMap,
DenseMap<Loop *, BasicBlockSet> &AftBlocksMap, DominatorTree &DT) {
- JamLoopBlocks.insert(JamLoop.block_begin(), JamLoop.block_end());
+ JamLoopBlocks.insert_range(JamLoop.blocks());
for (Loop *L : Root.getLoopsInPreorder()) {
if (L == &JamLoop)
@@ -122,7 +122,7 @@ static bool partitionOuterLoopBlocks(Loop *L, Loop *SubLoop,
BasicBlockSet &SubLoopBlocks,
BasicBlockSet &AftBlocks,
DominatorTree *DT) {
- SubLoopBlocks.insert(SubLoop->block_begin(), SubLoop->block_end());
+ SubLoopBlocks.insert_range(SubLoop->blocks());
return partitionLoopBlocks(*L, ForeBlocks, AftBlocks, *DT);
}
diff --git a/llvm/lib/Transforms/Utils/LoopUtils.cpp b/llvm/lib/Transforms/Utils/LoopUtils.cpp
index 96d7b3342349e..dd9f1d890b9c5 100644
--- a/llvm/lib/Transforms/Utils/LoopUtils.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUtils.cpp
@@ -701,7 +701,7 @@ void llvm::deleteDeadLoop(Loop *L, DominatorTree *DT, ScalarEvolution *SE,
// otherwise our loop iterators won't work.
SmallPtrSet<BasicBlock *, 8> blocks;
- blocks.insert(L->block_begin(), L->block_end());
+ blocks.insert_range(L->blocks());
for (BasicBlock *BB : blocks)
LI->removeBlock(BB);
diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
index 574ded9948aac..823af82191c5a 100644
--- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -2970,7 +2970,7 @@ void InnerLoopVectorizer::sinkScalarOperands(Instruction *PredInst) {
// may have failed to sink I's operands (recursively), which we try
// (again) here.
if (I->getParent() == PredBB) {
- Worklist.insert(I->op_begin(), I->op_end());
+ Worklist.insert_range(I->operands());
continue;
}
@@ -2985,7 +2985,7 @@ void InnerLoopVectorizer::sinkScalarOperands(Instruction *PredInst) {
// Move the instruction to the beginning of the predicated block, and add
// it's operands to the worklist.
I->moveBefore(PredBB->getFirstInsertionPt());
- Worklist.insert(I->op_begin(), I->op_end());
+ Worklist.insert_range(I->operands());
// The sinking may have enabled other instructions to be sunk, so we will
// need to iterate.
diff --git a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
index 08e16b53cd1e7..6c0100389d736 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
@@ -582,7 +582,7 @@ static SmallVector<VPUser *> collectUsersRecursively(VPValue *V) {
if (isa<VPHeaderPHIRecipe>(Cur))
continue;
for (VPValue *V : Cur->definedValues())
- Users.insert(V->user_begin(), V->user_end());
+ Users.insert_range(V->users());
}
return Users.takeVector();
}
|
|
@llvm/pr-subscribers-llvm-ir Author: Kazu Hirata (kazutakahirata) ChangesDenseSet, SmallPtrSet, SmallSet, SetVector, and StringSet recently Full diff: https://github.com/llvm/llvm-project/pull/132591.diff 8 Files Affected:
diff --git a/llvm/lib/IR/Type.cpp b/llvm/lib/IR/Type.cpp
index 0d400bdbdc775..34732f75ebecb 100644
--- a/llvm/lib/IR/Type.cpp
+++ b/llvm/lib/IR/Type.cpp
@@ -553,7 +553,7 @@ Error StructType::checkBody(ArrayRef<Type *> Elements) {
if (Ty == this)
return createStringError(Twine("identified structure type '") +
getName() + "' is recursive");
- Worklist.insert(Ty->subtype_begin(), Ty->subtype_end());
+ Worklist.insert_range(Ty->subtypes());
}
return Error::success();
}
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 5934f7adffb93..ed86a10c3a25f 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -7215,7 +7215,7 @@ void Verifier::verifyCompileUnits() {
auto *CUs = M.getNamedMetadata("llvm.dbg.cu");
SmallPtrSet<const Metadata *, 2> Listed;
if (CUs)
- Listed.insert(CUs->op_begin(), CUs->op_end());
+ Listed.insert_range(CUs->operands());
for (const auto *CU : CUVisited)
CheckDI(Listed.count(CU), "DICompileUnit not listed in llvm.dbg.cu", CU);
CUVisited.clear();
diff --git a/llvm/lib/LTO/LTO.cpp b/llvm/lib/LTO/LTO.cpp
index b12be4ac86aae..97d23feff230f 100644
--- a/llvm/lib/LTO/LTO.cpp
+++ b/llvm/lib/LTO/LTO.cpp
@@ -1439,9 +1439,9 @@ class InProcessThinBackend : public ThinBackendProc {
AddStream(std::move(AddStream)), Cache(std::move(Cache)),
ShouldEmitIndexFiles(ShouldEmitIndexFiles) {
auto &Defs = CombinedIndex.cfiFunctionDefs();
- CfiFunctionDefs.insert(Defs.guid_begin(), Defs.guid_end());
+ CfiFunctionDefs.insert_range(Defs.guids());
auto &Decls = CombinedIndex.cfiFunctionDecls();
- CfiFunctionDecls.insert(Decls.guid_begin(), Decls.guid_end());
+ CfiFunctionDecls.insert_range(Decls.guids());
}
virtual Error runThinLTOBackendThread(
diff --git a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
index 2bec5559abd16..8a30a3e8d22e2 100644
--- a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
+++ b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
@@ -1972,7 +1972,7 @@ class LowerMatrixIntrinsics {
if (CurrI->mayHaveSideEffects() || CurrI->mayReadFromMemory())
return;
ToHoist.push_back(CurrI);
- WorkList.insert(CurrI->op_begin(), CurrI->op_end());
+ WorkList.insert_range(CurrI->operands());
}
sort(ToHoist, [this](Instruction *A, Instruction *B) {
diff --git a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
index d1c7eaf85de7e..ca90bb65f5708 100644
--- a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
@@ -102,7 +102,7 @@ static bool partitionOuterLoopBlocks(
Loop &Root, Loop &JamLoop, BasicBlockSet &JamLoopBlocks,
DenseMap<Loop *, BasicBlockSet> &ForeBlocksMap,
DenseMap<Loop *, BasicBlockSet> &AftBlocksMap, DominatorTree &DT) {
- JamLoopBlocks.insert(JamLoop.block_begin(), JamLoop.block_end());
+ JamLoopBlocks.insert_range(JamLoop.blocks());
for (Loop *L : Root.getLoopsInPreorder()) {
if (L == &JamLoop)
@@ -122,7 +122,7 @@ static bool partitionOuterLoopBlocks(Loop *L, Loop *SubLoop,
BasicBlockSet &SubLoopBlocks,
BasicBlockSet &AftBlocks,
DominatorTree *DT) {
- SubLoopBlocks.insert(SubLoop->block_begin(), SubLoop->block_end());
+ SubLoopBlocks.insert_range(SubLoop->blocks());
return partitionLoopBlocks(*L, ForeBlocks, AftBlocks, *DT);
}
diff --git a/llvm/lib/Transforms/Utils/LoopUtils.cpp b/llvm/lib/Transforms/Utils/LoopUtils.cpp
index 96d7b3342349e..dd9f1d890b9c5 100644
--- a/llvm/lib/Transforms/Utils/LoopUtils.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUtils.cpp
@@ -701,7 +701,7 @@ void llvm::deleteDeadLoop(Loop *L, DominatorTree *DT, ScalarEvolution *SE,
// otherwise our loop iterators won't work.
SmallPtrSet<BasicBlock *, 8> blocks;
- blocks.insert(L->block_begin(), L->block_end());
+ blocks.insert_range(L->blocks());
for (BasicBlock *BB : blocks)
LI->removeBlock(BB);
diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
index 574ded9948aac..823af82191c5a 100644
--- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -2970,7 +2970,7 @@ void InnerLoopVectorizer::sinkScalarOperands(Instruction *PredInst) {
// may have failed to sink I's operands (recursively), which we try
// (again) here.
if (I->getParent() == PredBB) {
- Worklist.insert(I->op_begin(), I->op_end());
+ Worklist.insert_range(I->operands());
continue;
}
@@ -2985,7 +2985,7 @@ void InnerLoopVectorizer::sinkScalarOperands(Instruction *PredInst) {
// Move the instruction to the beginning of the predicated block, and add
// it's operands to the worklist.
I->moveBefore(PredBB->getFirstInsertionPt());
- Worklist.insert(I->op_begin(), I->op_end());
+ Worklist.insert_range(I->operands());
// The sinking may have enabled other instructions to be sunk, so we will
// need to iterate.
diff --git a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
index 08e16b53cd1e7..6c0100389d736 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
@@ -582,7 +582,7 @@ static SmallVector<VPUser *> collectUsersRecursively(VPValue *V) {
if (isa<VPHeaderPHIRecipe>(Cur))
continue;
for (VPValue *V : Cur->definedValues())
- Users.insert(V->user_begin(), V->user_end());
+ Users.insert_range(V->users());
}
return Users.takeVector();
}
|
ipazarbasi
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DenseSet, SmallPtrSet, SmallSet, SetVector, and StringSet recently
gained C++23-style insert_range. This patch uses insert_range with
iterator ranges. For each case, I've verified that foos is defined as
make_range(foo_begin(), foo_end()) or in a similar manner.